Closed
Bug 415444
Opened 17 years ago
Closed 17 years ago
Back/forward button history drop menus don't work anymore
Categories
(Firefox :: General, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta4
People
(Reporter: deb, Assigned: asaf)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008020304 Minefield/3.0b3pre
Back/forward button drop menus no longer work properly -- instead of taking you back/forward to the selected item in history, it just goes back/forward one page.
Example:
In a tab go to slashdot.org, then digg.com, then hugg.com, then cnn.com. Click and hold the back button to get the history drop menu. Select "slashdot.org".
Expected: navigate to slashdot.org.
Actual: navigate to hugg.com
Same behaviour for the forward button.
Flags: blocking-firefox3?
Comment 1•17 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020304
WFM, thus probably a Mac only issue do to click&hold being confused (maybe due to bug 414797 not being properly fixed?).
Comment 2•17 years ago
|
||
I only see this problem (on OS X) with the menu brought up by
click&hold -- not with a menu raised by right-click or control-click.
So I suppose you're right, Simon, that this is a click&hold issue.
(I tested with today's nightly on OS X 10.5.)
Assignee | ||
Comment 3•17 years ago
|
||
Updated•17 years ago
|
Attachment #301554 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #301554 -
Flags: approval1.9?
Comment 5•17 years ago
|
||
Shouldn't the fix be within the Mac-specific code? (Checking event.target or something, I didn't really look into what's going on here.)
Assignee | ||
Comment 6•17 years ago
|
||
It does not hurt the default case, so I would rather not complex things even more.
Comment 7•17 years ago
|
||
Well, it hurts extensibility. It's an edge case, though. I can think of an extension not liking this, but that doesn't mean such an extension really exists or will exist.
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta4
Assignee | ||
Comment 9•17 years ago
|
||
mozilla/browser/base/content/browser.xul 1.429
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Attachment #301554 -
Flags: approval1.9?
Comment 10•17 years ago
|
||
This missing b3 makes b3 unusable for me. My only choice is to surf the nightlies I suppose. Seems like there could be b3 backlash.
/be
Comment 11•17 years ago
|
||
Dao, Alex, anyone: I'm on the nightly update train, happy again, don't mean to be picky -- but the delay seems near a second to get the drop down. A bit too long? What does the Apple HIG say?
/be
Comment 12•17 years ago
|
||
Sorr, Mano's bug and fix -- didn't mean to leave him out. My Mac one button life has schooled me implicitly on when to expect a different mode due to time passing by, and the delay to get the back history dropdown just seems a bit too long.
/be
Comment 13•17 years ago
|
||
The delay is 500 ms, which does seem quite long. I've never used it, though, since it's Mac-only.
Comment 15•17 years ago
|
||
Should I file a bug on the overlong delay?
/be
Comment 16•17 years ago
|
||
Yes, I think so.
Comment 17•17 years ago
|
||
Filed bug 417607.
/be
Verified FIXED, modulo bug 417607, which Brendan filed (comment 17).
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022104 Minefield/3.0b4pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•