As above. Right now addons that are compatible with more than one but not all OSes cause an issue. Moving this from 399913 which was more general, but read comments there: https://bugzilla.mozilla.org/show_bug.cgi?id=399913

This will change the XML returned to the client, FYI.

Will we change to a new version in the url or will we have to take the hit breaking 3b3?

New url, details to follow shortly.

The logic still needs fixing, but this decouples that from the Addons Mgr. Available for testing on lthomson.khan-vm

Need to change this a bit: some addons have different xpis per os. Desired XML will change to <install hash='...' os=''>...</install>. If no os attribute is supplied default should be ALL.

Committed patch to trunk in r10634.

in r10671: Add translation table for outputting the platform oses the client is looking for. Kind of an evil hardcoded hack which I am reproducing from http://mxr.mozilla.org/mozilla/source/webtools/update/update/VersionCheck.php Both of these should get fixed at the same time, and draw on the AMO db. Will file a bug for that separately. (Refs #417606 as well)

Laura, any update on this bug?

I tested this with 3.0.3 but requesting review from Mossop to be sure.

Comment on attachment 343042 [details] Sample output for the classic test case, Cooliris (Piclens) Yeah looks good. I'm assuming the search API returns the same sort of data.

Dave, it's exactly the same format (uses the same code).

Comment on attachment 343041 [details] [diff] [review] Patch to return one install stanza per OS, also lists compatible OSes correctly. Output had: <install hash="sha1:a582200fd6343cc9c75a8d7fabd27a6058df34b1" os="WINNT"> https://addons.mozilla.org/downloads/file/38892/cooliris__formerly_piclens_-1.8.3.14081-fx-win.xpi </install> − <install hash="sha1:ff19975681de4ce3fd39c2ab39259651cc27b70b" os="Darwin"> https://addons.mozilla.org/downloads/file/38893/cooliris__formerly_piclens_-1.8.3.14081-fx-macosx.xpi </install> I would prefer to see some tests to verify something like that, though. Do you have any time to write some against the spec mossop provided?

I'm not sure how to go about writing unit tests for AMO, is there any docs to go on? I might be able to find some spare time if it isn't too involved.

I can write a unit test but not in time for this freeze/push. (Since this bug was for Monday's freeze and tomorrow's push) I also think it would be nice to have a client test, which is obviously in Mossop's court.

Oh client has already had automated tests for this since bug 417606 was fixed

In r19146. Writing a unit test depends on getting some test data that represents this edge case...which I guess depends on bug 459855. Calling this FIXED but I'll open a bug for the unit test.

mossop, which automated test in bug 417606 covers this? Or, Laura, is there a quick https://preview.addons.mozilla.org/en-US/firefox/api/1.1/* URL with which I can test?

https://preview.addons.mozilla.org/en-US/firefox/api/1.1/addon/5579 or use the search for PicLens.

Verified FIXED; the URL from comment 21 shows both OSs, while https://addons.mozilla.org/en-US/firefox/api/1.1/addon/5579 only shows me Windows. https://bugzilla.mozilla.org/show_bug.cgi?id=399913#c33 helped me understand this; sorry for not having it sink in before.