Closed
Bug 419038
Opened 17 years ago
Closed 17 years ago
Replace nsISupportsArray usage for nsMsgCompose State Listeners
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Another step along the road to removing nsISupportsArray. This one replaces the nsISupportsArray handling of state listeners that we have in nsMsgCompose with an nsTObserverArray instead.
Couldn't find a way to test this via xpcshell tests, so no tests with this one.
Attachment #304983 -
Flags: superreview?(neil)
Attachment #304983 -
Flags: review?(neil)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 304983 [details] [diff] [review]
The fix
>+ PRInt32 index = mStateListeners.IndexOf(aStateListener);
>+ if (index == -1)
>+ return NS_ERROR_FAILURE;
>
>+ mStateListeners.RemoveElement(aStateListener);
>+ return NS_OK;
Use RemoveElement ? NS_OK : NS_ERROR_FAILURE as per AppendElement.
Attachment #304983 -
Flags: superreview?(neil)
Attachment #304983 -
Flags: superreview+
Attachment #304983 -
Flags: review?(neil)
Attachment #304983 -
Flags: review+
|
Assignee | |
Comment 2•17 years ago
|
||
Patch checked in with comment addressed -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Drop replace nsISupportsArray usage for nsMsgCompose State Listeners → Replace nsISupportsArray usage for nsMsgCompose State Listeners
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•