When history sidebar shows results "By Site", it does not join with history visits to be superfast. However, if you import bookmarks or clear your history, the view will show all the sites. We can stay superfast but avoid displaying those hosts by using visit_count from the moz_places table. This could speed up "By Date and Site" view too.

actually visit_count is not realiable so this probably depends on Bug 416313

This will not block the final release of Firefox 3.

in the second query (the one with the additional conditions): - "WHERE h.hidden <> 1 AND h.rev_host = '.' " + "WHERE h.hidden <> 1 AND h.rev_host = '.' AND visit_count > 0 " - "WHERE h.hidden <> 1 AND h.rev_host <> '.' " + "WHERE h.hidden <> 1 AND h.rev_host <> '.' AND visit_count > 0 " h.visit_count would be more consistent, although it does not make any difference.

(In reply to comment #3) > h.visit_count would be more consistent, although it does not make any > difference. You are right, and because unbitrotting was necessary anyway, here comes the fixed patch.

Comment on attachment 312243 [details] [diff] [review] Use visit_count to filter out empty hosts (nit and unbitrot) r=me thanks.

Comment on attachment 312243 [details] [diff] [review] Use visit_count to filter out empty hosts (nit and unbitrot) fixes blocker bug 432197.

Comment on attachment 319658 [details] [diff] [review] with the test from bug 432197 a1.9=beltzner

Marking a blocker since it blocks bug 432197 and we are approving the patch.

Dietrich/Marco any performance concerns here? Looks like just an extra part of the where clause and no additional joins - but want to make sure...

Since we're now able to use moz_places.visit_count instead of joining against moz_historyvisits, this should not have a significant effect on performance.

Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.302; previous revision: 1.301 done Checking in toolkit/components/places/tests/unit/test_history_sidebar.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_history_sidebar.js,v <-- test_history_sidebar.js new revision: 1.4; previous revision: 1.3 done

backed out, tree is closed

Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.304; previous revision: 1.303 done Checking in toolkit/components/places/tests/unit/test_history_sidebar.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_history_sidebar.js,v <-- test_history_sidebar.js new revision: 1.6; previous revision: 1.5 done

(In reply to comment #10) > Dietrich/Marco any performance concerns here? Looks like just an extra part of > the where clause and no additional joins - but want to make sure... should not be a problem it's a simple check on a column already joined

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv