User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5 Build Identifier: mozilla firefox 3.0 beta i visited many sites, one of the was www.hotmail.com; i typed that in, and checked a few emails. after i checked my emails i went to www.hotmail.com, and i then saw a list of things relating to hotmail, "account created for west158@hotmail.com" etc, and so i deleted the history, tried it again and it still appeared; this a security and privacy hole i think. Reproducible: Always Steps to Reproduce: 1.type in hotmail.com 2.login 3.type hotmail.com in url 4. delete history 5. comes back Actual Results: 1.type in hotmail.com 2.login 3.type hotmail.com in url 4. delete history 5. comes back Expected Results: expected result, for history to go, im not bothered because im testing, but im warning people before it goes finished. p.s its a good idea, but it needs fixing.... it should of deleted hotmail.com and everything to do with hotmail; when the person deletes their history, etc.

I haven't seen this behaviour, but I have seen it reported elsewhere. In any event, while I understand the privacy concerns here, it isn't a bug that needs to be hidden for security reasons, so I'm unhiding it.

I see similar wierdness. When I delete individual sites from the history sidebar most just go away, but some leave the site "folder" sitting there even though it shows no pages in history. When I delete all of history through Clear Private Data a handful of empty site "folders" remain in the sidebar. The ones that persist in my sidebar are the ones that continue to autocomplete. And of course even just showing the site names could be a serious privacy problem for some people. Since most sites went and the ones that remain are my most regularly used sites (tinderbox, bugzilla, mxr, wikipedia, etc.) I suspect this may be due to places file format changes over time or corruption. If this is at all common to people who used early beta versions we'll want to clean this up. I could get a copy of my places file to a developer if they need it, but it's also worth testing to see if the problem can be reproduced by starting with an early beta and upgrading.

Blocking for investigation.

Dietrich and Dveditz to co-ordinate and try and figure this out.

there is one reporter report like this going back to beta3. http://reporter.mozilla.org/app/report/?report_id=RMO12034638241525&report_description=%25history%25&report_product=Firefox%2F3.0b3&selected[]=report_url&selected[]=host_hostname&selected[]=report_problem_type&selected[]=report_behind_login&selected[]=report_product&selected[]=report_gecko&selected[]=report_useragent&selected[]=report_buildconfig&selected[]=report_platform&selected[]=report_file_date&selected[]=report_description&show=25&product_family=&page=1 Product: Firefox/3.0b3 Gecko Version: 20080205 Platform: Win32 OS/CPU: Windows NT 5.1 Language: en-US Character Set: UTF-8 User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3 Build Config: --enable-application=browser --enable-update-channel=beta --enable-optimize --disable-debug --disable-tests --enable-update-packaging --enable-official-branding Date Reported: 2008-02-19 15:30:24 Description: Can't clear search bar history, no matter what I try. Even have "Remember what I type in forms and search bar" turned off. Clear Private Data doesn't work. Nothing works; it always shows suggestions when I start typing in the search bar.

a few more comments on beta 4 and 5, but its not clear if its a bug with trying to clear history after a user action, or just a problem in trying to find a way to perform the action.

I looked at Dan's database, and these are actually domains of bookmarked URIs. Also note that these are empty "site" folders, there are not visits shown. The main problem is a missing join in the "by site" query, which allows unvisited URIs to be used when generating the container list. Fix on the way for this. A secondary problem is that the database has some bookmarks which are orphaned (that row's |parent| column points to a folder id that does not exist in the database), which was fixed in bug 428133. That's why Dan was seeing site folders for domains that were not visibly bookmarked. The fix for the join problem will remove these containers, however the orphaned bookmarks are still in the database. I'll file a followup bug for removing these.

setting to P2 since it's not undeleted-history, but bookmarks. also, better patch in bug 419957.

Comment on attachment 319639 [details] [diff] [review] fix This patch covers comment #3, however, there is already solution proposed in bug 419957.

Thanks for investigating, glad it turned out to be bookmarks after all (even if not starred). What's the bug # for cleaning up the orphaned bookmarks?

marking fixed via bug 419957. > > What's the bug # for cleaning up the orphaned bookmarks? > filed bug 432578 for this

verified with rc2 on Win XP

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv