Closed Bug 420199 Opened 17 years ago Closed 14 years ago

Moving a lot of bookmarks in Library is quite slow (locks up browser)

Categories

(Firefox :: Bookmarks & History, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 472343

People

(Reporter: twentyafterfour+bz, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [TSnappiness])

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 I just imported a lot of bookmarks from my del.icio.us account, hoping to take advantage of the new sql-based bookmark system in Firefox 3... Once I imported about 1500 bookmarks I encountered several serious problems with the Bookmark Organizer interface. 1. Unable to drag+drop bookmarks into folders 2. Once I discovered the move option in the "Organize" menu, I selected all of my newly imported bookmarks and chose to move them into a new folder called "del.icio.us" ...This locked up the browser for several minutes and resulted in a complete duplication of everything in my bookmarks hierarchy, including the top level folders. I confirmed this by viewing the sqlite tables, I had nearly 7000 bookmarks, every single one was duplicated at least once. My attempt to clean this up manually has been only partially successful. Reproducible: Sometimes Steps to Reproduce: 1. import a lot of bookmarks (1000+) 2. select all of them with ctl+a 3. choose move from the "organize" menu 4. select a new sub-folder to move them to Actual Results: Browser appears to freeze for several minutes (on a high-performance system) and uses 100% CPU. Expected Results: Bookmarks moved to new folder. I would think that 5-10 seconds would seem reasonable for this operation. The underlying sqlite engine certainly could do this quickly, though updating the XUL interface would obviously add overhead. I'm going to start with a fresh profile to see if this is easily reproducible, however, this happened several times on my current profile which is mostly clean having been recently created for testing the Firefox 3 betas.
Version: unspecified → Trunk
After starting with a fresh places.sqlite and installing the latest trunk build I still had the same issues with 100% cpu freezes, though I was eventually able to move the 1400 bookmarks after several attempts.
Component: Bookmarks → Places
Keywords: perf
QA Contact: bookmarks → places
Ok I just tried the same procedure on windows with Beta 3 and it has the same or at least a similar issue. The browser freezes for 5 minutes while moving the bookmarks, then the bookmarks are all gone, it's as if I deleted them rather than moving them to "unfiled bookmarks"
by the way, it seems that my report should have said reproducible: always
OS: Linux → All
Same issue with today's latest trunk build on windows. Note: it didn't make the bookmarks disappear this time but I didn't move them to "unfiled bookmarks," instead I moved them to a folder which I created. This worked but it took several minutes while the browser appeared to be crashed. System Specs: 2.1ghz Core 2 Duo with 3GB Ram, 7200rpm hard drive.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Having trouble moving bookmarks in Organize Bookmarks window → Moving a lot of bookmarks in Library is slow
Severity: major → normal
The new title on this bug really limits the scope of what I reported. If it were only slow then I wouldn't consider it a serious bug. The issue is that it doesn't work reliably and locks the browser during the "slowness" with no indication that work is being done. This will lead users to believe that the browser has crashed. To make matters worse, sometimes the move operation corrupts or loses bookmarks.
Summary: Moving a lot of bookmarks in Library is slow → Moving a lot of bookmarks in Library is quite slow (locks up browser)
is this reproducible with rc1? perhaps a dupe of bug 527521
Depends on: 432706
Flags: blocking-firefox3.1?
Removing the blocking request, since it depends on a 3.1 blocker.
Flags: blocking-firefox3.1?
Whiteboard: [TSnappiness]
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Duplicate of bug 472343 and fixed on trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.