Closed Bug 420454 Opened 17 years ago Closed 17 years ago

Drop nsISupportsArray usage from nsSmtpService

Categories

(MailNews Core :: Composition, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch The fix (diff -w) (deleted) — Splinter Review
Here's another patch for dropping nsISupportsArray usage. This time from nsISmtpService and a few internal uses in nsSmtpService and nsSmtpDataSource. xpcshell test for most of nsSmtpService included. Note for nsSmtpDataSource::mServerArcsOut and nsSmtpDataSource::mServerRootArcsOut I have set the size at construction time because we know they will be a fixed size. This should save reallocations and time when constructing/filling them. nsSmtpDataSource also has an mObserver, this is only used for Add and Remove, but I didn't want to remove the mObserver member variable as the documentation says that we should hold strong references to the observers. So I've just modified it not to use nsISupportsArray. I did some whitespace tidy up as well as the functions seemed to warrant it.
Attachment #306724 - Flags: review?(neil)
Attached patch The fix (normal patch) (deleted) — Splinter Review
I'm not sure we actually use nsSmtpDataSource. I hope not ;-)
(In reply to comment #2) > I'm not sure we actually use nsSmtpDataSource. I hope not ;-) See bug 420503. I think I can probably just drop those changes, or we can commit them anyway depending on when the two patches are reviewed relative to each other.
Comment on attachment 306724 [details] [diff] [review] The fix (diff -w) OK, r=me on the nsSmtpServer changes.
Attachment #306724 - Flags: review?(neil) → review+
Depends on: 420503
Comment on attachment 306724 [details] [diff] [review] The fix (diff -w) Ignore the nsSmtpDataSource changes, I'll just drop them from the patch once bug 420503 is committed.
Attachment #306724 - Flags: superreview?(bienvenu)
Comment on attachment 306724 [details] [diff] [review] The fix (diff -w) nice. I think the redirector stuff is going away - don't know if that's going to cause conflicts or not.
Attachment #306724 - Flags: superreview?(bienvenu) → superreview+
Summary: Drop nsISupportsArray usage from nsSmtpService and nsSmtpDataSource → Drop nsISupportsArray usage from nsSmtpService
Patch checked in, I adjusted for the redirector and nsSmtpDataSource removals.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: