bhearsum@mozilla.com (:bhearsum) Reporter
	Description • 17 years ago

Over at http://hera.senecac.on.ca/tryserver/, Adam has created a nice front page for the try server. It would be _awesome_ to get this into the try server tree. It would require a little bit of customization to be useful:
1) Login/Register links should be optional.
2) Links at the bottom should be read in from a config file to make them easily changeable.

The code would belong in mozilla/webtools/buildbot-try. It may or may not require changes to the existing cgi code; depends on the implementation.

Shaver suggested this:
10:01 < shaver> block of JS at the top for configuration/
10:01 < shaver> or it could load config.js
10:01 < shaver> so that you can separate config from upstream
10:01 < shaver> that way you don't get conflicts

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 1 • 17 years ago

Out of curiosity, is there any progress here? (No rush, simply inquiring)

	Adam Delyea
	Comment 2 • 17 years ago

Simple js config file. All text is in the config.js, except for the page title.

	Adam Delyea
	Comment 3 • 17 years ago

Simple js config file. All text is in the config.js, except for the page title.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 4 • 17 years ago

Hey Adam, I'm not sure what format this file is. Can you either fix the mime type or attach an actual patch?

	Adam Delyea
	Comment 5 • 17 years ago

Comment on attachment 311791 [details]
Simple Javascript config file and front page.

Fixed mime type

	Adam Delyea
	Comment 6 • 17 years ago

Comment on attachment 311791 [details]
Simple Javascript config file and front page.

>PK����pWz8?�f���&�����scripts/config.js�TMo�@=�R��(H$��]���!!*�H�T��c{�z��GB
>�wf�	
>�T�����{3of<��53p� +��%���3�B�B�
>��5Jݵt���,�7JK]o����!ɭNb��D[�5�rB���&w]=�4?��P��:~�'��uh|X����ͫ|����i賝XX�-�1k4YJ._F�Y�/<0@���9�K�Rb� ,0��Zho8Bg�r7�M�t�;R��ˡu�c�7!�}/�d�j&T0I	�1H �U��ӛ��9��*����Z(�}�Њc�&ė���@�k�ATD���m(��N��VC��@z#X_��9��}��8vKum	j�q��Y�Q���+~��Q�����h�V�O��F{�z�)�v�di7܏ |̈́dE�@P�OoΗ4w�C%�c�K�M�}[큑T�C?vn@���n�b[P����#�e[�.���7�J5�\{E��	X���ڰ5�
>�Z���Hn�t8�B}�4��窰���3��hU�ob��~��f���sB�����$�"�P���1�ŋB�Ԣ*9վƄ���C1�ᣦ��:"ey��L�a���V����Y���>]g�\w�Ҫ0,��i<�jsv�����8��Ƅ>�0��F`�h�*����ͩDG��'7,o�[yŝ�ϭ__���*5�a&#Nw�oF�_�~!>��=��q3����0"�b���O�`���PK�����Uz8��e}���M��
>���index.html�Tmo�0��I�'��L��D����T�R��ke����F�I���L3�L�T$���^�{�GR��?~�$��&����|�3+��%�5�ķ���7�3gy�X]�X�����7�f�K?m)�=�	dž�L�F#�lI�3癬�5:����h�hlV2�9VQ~&xAK�Y9�ķ����SR�oA�-3�R���R�<wimJF�Jv�c3^Oi镴8�a�'�A�#�_wC!��O�ی�n%�9�N��г&S�*)aS�2'��p�*���!L�N>�O<����F(���]=F4]c�4�UW��^YRsNZ=�hZ�� �R�Z'aZ�nAjʶ�D�gP�FA��0�F�BZV:
>�OX.��ą�	3
>C�wAyv�����}��^�S��aG}���/�e����w����8�x��l�U�&�eX����(�c�q�[$�>�iD�Yg����R��70�7v�?�����lG�C���~��d��D~PK����pWz8?�f���&���������� �������scripts/config.jsPK�����Uz8��e}���M��
>�������� ������index.htmlPK������w��������

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 7 • 17 years ago

Sorry about taking so long to get to this, Adam.

This looks good, I've got a couple of nits though:
* Login/Register links should be optional. Need some logic in login().
* config.js should only be variables, no functions. Another file, index.js or tryserver.js or something include config.js.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 9 • 17 years ago

Comment on attachment 314126 [details]
Tryserver index config files

This looks good.

I've got a couple feature requests if you have time:
* Make the favicon configurable
* Make it optionally possible to have a background

	Adam Delyea
	Comment 10 • 17 years ago

I can't insert javascript to make the favicon configurable.

In order to make that configurable, I'd have to implement the index page using some kind of server side language. I was thinking that it would make it more useful/useable if you didn't have to use a server side language to use this.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 11 • 17 years ago

(In reply to comment #10)
> I can't insert javascript to make the favicon configurable.
> 
> In order to make that configurable, I'd have to implement the index page using
> some kind of server side language. I was thinking that it would make it more
> useful/useable if you didn't have to use a server side language to use this.
> 

Yeah, I think it'd be overkill to throw this into the CGI.

Can't you just do something like:
<title>Seneca Try Server</title>
favicon()
<script>...
etc.

And favicon could write out the whole <link> tag, or write out nothing.

I also noticed that <title> is hardcoded - can you fix that?

	Adam Delyea
	Comment 12 • 17 years ago

I don't think you can have any javascript statements inside the <head> tag. All it does is print out the javascript tags. So, anything in the <head> tag has to be hardcoded, unless it's coded on the server side.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 13 • 17 years ago

Hm, OK. In that case let's just make the title "Try Server" and lose the favicon.

	Mike Shaver (:shaver -- probably not reading bugmail closely)
	Comment 14 • 17 years ago

(In reply to comment #12)
> I don't think you can have any javascript statements inside the <head> tag.

That should very much not be the case; <script> in <head> is recommended for many things, in fact.  Can you put a test case here or in another bug?

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 15 • 17 years ago

Adam, can you add those in? I think it's pretty important for the title in particular to be easily customizable.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 16 • 16 years ago

Hey Adam, are you going to do this?

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 17 • 16 years ago

No response here, reassigning =\.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 18 • 16 years ago

Mass change of target milestone.

	Chris Cooper [:coop] (he/him)
	Comment 19 • 15 years ago

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

	Lukas Blakk [:lsblakk] use ?needinfo Assignee
	Comment 20 • 14 years ago

We will be re-visiting the web interface once try-as-branch is rolled out.

	Lukas Blakk [:lsblakk] use ?needinfo Assignee
	Comment 21 • 14 years ago

Try-as-branch has been rolled out, try enhancements to how try actually works now are being tracked in bug 572808.  This bug is so far out of date that I am closing it and once we have (if we return to) a web interface we can incorporate user friendliness into the design out the gate, further bugs on its design can be filed as needed.