Notification bars in the addons manager are currently using: http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/extensions/question.png However, these notification bars do not actually ask the user a question. Once an information icon is landed in toolkit, these notification bars should use it instead.

Alex: Has the information icon finally landed?

yep http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/icons/information-16.png

wait, actually we should take care of this problem with the new notification bar styling, where for information we use: background http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/icons/informationBar-60.png icon http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/icons/informationBarIcon-16.png I'm going to dupe this to the bug for making those changes.

This is basically a bug in extensions.js.

Robert: question.png was introduced in bug 329045 for notifications that don't ask any question. Please comment if I'm missing something.

It was but bug 329045 does not depend on this bug being fixed for it to be fixed... especially since that bug was specifically for Firefox 2.0. btw: some of the notifications do ask a question so both the info and the question icons will be needed.

Yes, we should take a close look at the current notifications and use info/warning/question icons as appropriate. I added the dependency merely for the curious since the parts that are relevant for this bug made it into 1.9.

We really don't seem to ask a question in any of the notifications ... once we do, we should use chrome://global/skin/icons/question-16.png, which allows us to remove question.png.

Comment on attachment 320158 [details] [diff] [review] patch Looks ok to me

Comment on attachment 320158 [details] [diff] [review] patch a+ schrep - need you guys to test the nighties for this tomorrow since we don't have any room for respins.

Checking in toolkit/mozapps/extensions/content/extensions.js; /cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v <-- extensions.js new revision: 1.177; previous revision: 1.176 done Checking in toolkit/themes/pinstripe/mozapps/jar.mn; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v <-- jar.mn new revision: 1.29; previous revision: 1.28 done Checking in toolkit/themes/winstripe/mozapps/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v <-- jar.mn new revision: 1.38; previous revision: 1.37 done

The notification icon is shown with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050920 Minefield/3.0pre => VERIFIED. Aleksej, how does it look like on Linux? Is the selected GTK2 theme's default notification icon shown?

Sorry, my fault. This is XP only => Verified.

No, it's all platforms.