Running checksetup.pl on Bugzilla 3.x.3+ displays: ... Removing existing compiled templates ... Precompiling templates... Выпраўленне дазволаў файлаў... Checking for GraphViz (any) ok: found The "unreadable" text is because I have be, en, fr, and ru installed, and so it takes the first language available, alphabetically. If I add a symlink aa -> fr, then I get messages in french. If it cannot find the language I'm using in my shell, it should fall back to english so that we have a chance to understand what checksetup.pl displays.

checksetup wasn't localizable in 3.0, so this isn't affecting 3.0, as far as I know.

Also it should correctly derive 'fr' from 'fr_CH.UTF-8' LANG value

(In reply to comment #2) > Also it should correctly derive 'fr' from 'fr_CH.UTF-8' LANG value Yes, actually, supposedly it's already doing that, but the code isn't working for some reason. I think it might be the ".UTF-8" that's confusing it, not the _CH.

This patch fixes two things: 1) checksetup.pl parses LC_CTYPE for us, assuming some distros set LC_CTYPE to e.g. fr_CH.UTF-8 which should be read as fr-CH. 2) checksetup.pl also makes the assumption that if fr-CH is not present, it will look for fr. 3) If neither fr-CH nor fr is installed, falls back to en instead of the alphabetical list of languages found, which in 99% of cases won't return the language we want (and in my case, it was returning belorussian because it comes before fr, en and ru).

Comment on attachment 312125 [details] [diff] [review] patch, v1 >Index: checksetup.pl Put all this stuff into Bugzilla::Install::Util instead of into checksetup.pl directly. >+ # It's pretty sure that there is no language pack of the form fr-CH >+ # installed, so we also include fr as a wanted language. The template code should be doing that fallback itself. If it isn't, that's a bug. >Index: Bugzilla/Install/Util.pm >- if (!@usedlanguages && $params->{use_languages}) { >- @usedlanguages = @supported; >- } Hm, that doesn't defeat use_languages?

Comment on attachment 312125 [details] [diff] [review] patch, v1 This is good, r=Wurblzap. For this particular use case (locale always being a single string only; users *cannot* specify a list of languages even if they wanted), I'm even fine with the region part of the code being cut off so that only the language remains. (Nit: perhaps you should re-word "It's pretty sure" to "It's pretty common".) During testing, it turned out that setlocale returns unsuitable values on Windows. I filed bug 425620 for this.

Hm, I missed Max' comment somehow. (In reply to comment #5) > (From update of attachment 312125 [details] [diff] [review]) > >Index: checksetup.pl > > Put all this stuff into Bugzilla::Install::Util instead of into checksetup.pl > directly. I agree with the move out of checksetup.pl; this should be done. > >+ # It's pretty sure that there is no language pack of the form fr-CH > >+ # installed, so we also include fr as a wanted language. > > The template code should be doing that fallback itself. If it isn't, that's a > bug. No, it's not. See bug 258246. Users must be able to prefer fr-CH over en over fr. It's good that this fallback is done only in the setlocale case. > >Index: Bugzilla/Install/Util.pm > >- if (!@usedlanguages && $params->{use_languages}) { > >- @usedlanguages = @supported; > >- } > > Hm, that doesn't defeat use_languages? No, its real work is done some 20 lines or so above.

Okay, approved with the code moved into a subroutine in Install::Util.

Max, I'm very sorry I accidentally overrode your r-. This was not my intention. I had kept the attachment open for a long time and hadn't noticed your flag change -- it was still at r? for me. Had I seen your flag change, I'd commented only without changing the flag.

Here is the patch I'm going to check in. Carrying forward r+ per discussion with mkanat on IRC.

Adding POD to the previous patch.

OK, the issue about 3.0 is unrelated to this bug and also affects 3.2. I will file a separate bug for it. So this bug and this patch are only about 3.2.

Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.557; previous revision: 1.556 done Checking in Bugzilla/Install/Util.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v <-- Util.pm new revision: 1.12; previous revision: 1.11 done

(In reply to comment #12) > OK, the issue about 3.0 is unrelated to this bug and also affects 3.2. I will > file a separate bug for it. I filed bug 425746.