Closed
Bug 425746
Opened 17 years ago
Closed 17 years ago
Bugzilla::Template::precompile_templates() doesn't flush template_include_path_ correctly
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Follow-up of bug 425288:
Before precompiling templates, Bugzilla::Template::precompile_templates() flush template_include_path_ to not mess with other languages already compiled. But it forgets to flush it once more before leaving, meaning that template_include_path_ still contains the last language compiled (in my case: Russian). And so Bugzilla->template_inner will subsequently reuse it instead of recreating it for real, based on $ENV{'HTTP_ACCEPT_LANGUAGE'}. This affects 3.0 and 3.2.
|
||
Comment 1•17 years ago
|
||
Comment on attachment 312303 [details] [diff] [review]
patch, v1
Sure, that looks fine.
Attachment #312303 -
Flags: review?(mkanat) → review+
|
|
||
Comment 2•17 years ago
|
||
On checkin, add a comment that explains why you're only deleting template_include_path_ and not all of the other per-language variables.
Flags: approval3.0+
Flags: approval+
|
Assignee | |
Comment 3•17 years ago
|
||
(In reply to comment #2)
> On checkin, add a comment that explains why you're only deleting
> template_include_path_ and not all of the other per-language variables.
Huh? Other per-language variables are not set when recompiling templates. That's the only one which is defined AFAIK.
|
|
Assignee | |
Comment 4•17 years ago
|
||
tip:
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v <-- Template.pm
new revision: 1.88; previous revision: 1.87
done
3.0.3:
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v <-- Template.pm
new revision: 1.68.2.6; previous revision: 1.68.2.5
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•