User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040604 Minefield/3.0pre Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040604 Minefield/3.0pre You can auto-complete URL's by just typing "apple" in the URL bar and hitting CMD-Enter which adds a ".com" or SHIFT-Enter which adds a ".net" or SHIFT-CMD-Enter which adds a ".org" extension. This works fine in Firefox 2.0.0.13. In Minefield using the CMD-Enter or SHIFT-CMD-Enter gives a MacOSX warning sound (but the command itself works). There is something with the CMD key. Reproducible: Always Steps to Reproduce: 1. Type in the URL bar "mozilla" 2. Hit CMD-Enter (now it gives the warning sound)

This is similar to bug 376077, which was fixed a few months ago. I'll add a comment to that bug pointing to this one.

Yup, we need to fix this in toolkit or XUL code as Jesse suggested in bug 376077.

the event handler should call |preventDefault| of the event.

This happens on 10.4 too (not just 10.5).

Yeah, we need a preventDefault here, since we're eating the event.

Just adding a preventDefault to canonizeURL isn't fixing all the cases. There's some strange interactions going on between the browser.js code and the autocomplete handlers, need to investigate further.

I poked at this, there's a case where if the autocomplete throbber is visible, we still get this, kinda weird.

Oh, of course. That case would be when we hit the "enter after search" code, which ends up holding on to the event and calling the ontextentered handler after the search finishes. By that time the event would have already been dispatched with no one to preventDefault() it. Not sure there's an easy way to fix that, maybe we can just always preventDefault that event from autocomplete code? It's default action is never useful, right?

Maybe we can just always preventDefault Enter events? I was conservative and made this Mac-only, and only preventDefault when for Meta+Enter.

Comment on attachment 316290 [details] [diff] [review] patch There's no easy way to test this as far as I know, since it involves the system default action.

Comment on attachment 316290 [details] [diff] [review] patch a1.9+=damons

mozilla/toolkit/content/widgets/autocomplete.xml 1.139

Verified fixed in latest trunk (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre)

Verified using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre too.

I don't think, this CMD-beep bug is really fixed. Yes, CMD-ENTER and CMD-SHIFT-ENTER now works, no beep anymore. But when trying to cycle thru open windows, it still doesn't work, it just beeps. See the bug 427410. Open the Bookmarks or Add-ons window besides the browser window. Try to cycle thru them by holding CMD and hitting < (on my German keyboard layout). Just a warning beep, no action. Major bug. Works in FF 2.0.0.14 still fine.

If you're hearing beeps for actions other than Cmd+Enter in the location bar, then it isn't related to this bug.