Closed Bug 429689 Opened 17 years ago Closed 17 years ago

Land new windows icons (20080418)

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: faaborg, Assigned: reed)

References

()

Details

Attachments

(2 files)

A new drop of windows icons is ready: http://people.mozilla.com/~faaborg/files/granParadisoUI/icons/iconDrop-20080418.zip Note: there is one dependency, if bug 429688 is not complete then do not land -Toolbar.png -Toolbar-aero.png -Toolbar-small.png -Toolbar-small-aero.png
Flags: blocking-firefox3?
New files just arrived, hold off on landing this. I'll try to get an updated version up in an hour or so.
Assignee: nobody → reed
Ok, here is the updated icon drop: http://people.mozilla.com/~faaborg/files/granParadisoUI/icons/iconDrop-20080418-1.zip Still dependent on bug 429688, or you can land with removing the 4 toolbar files.
Need blanket a1.9= for icon landing...
a=beltzner, we need to up the max attachment size again, I guess.
Attached file iconDrop for 2008-04-18 (take 2) (deleted) —
Attachment #316474 - Flags: approval1.9?
Attachment #316474 - Attachment is patch: false
Attachment #316474 - Attachment mime type: text/plain → application/zip
Attachment #316474 - Flags: approval1.9? → approval1.9+
The tree is red/orange right now, and I have a couple of other things to do currently, so I'll land this later tonight.
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3
Blocks: 424603
I'm going ahead and committing the parts of this I can, but there are a couple of issues that need to be addressed: * browser/themes/winstripe/browser/Icon.png and Icon-aero.png are actual Firefox logos, which are not supposed to be outside of other-licenses/, as the logo is under a different license than the other browser/ code. I did not commit these new icons because of that. * browser/themes/winstripe/browser/preview.png and preview-aero.png shouldn't even contain the word Firefox, as nothing specific to the Firefox name should be under browser/, but it seems that's been a problem for a while (including Firefox 2). It really should be generic enough that anybody who builds browser/ without official branding wouldn't see the Firefox text, but since it's only the word written in the official font without the logo, it may be ok... * Is browser/themes/winstripe/browser/wrench.png one of the FAMFAMFAM icons? * browser/themes/winstripe/browser/places/libraryToolbar.png and libraryToolbar-aero.png just look like a combined version of organize.png, view.png, and importAndBackup.png. What's the purpose of this? Why not just keep the separate icons? Keeping duplicate copies of these icons just seems bad. * I left browser/themes/winstripe/browser/Toolbar* alone until bug 429688 is handled. Checking in browser/themes/winstripe/browser/Go-arrow-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow-aero.png,v <-- Go-arrow-aero.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/Go-arrow-rtl-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow-rtl-aero.png,v <-- Go-arrow-rtl-aero.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/Info-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Info-aero.png,v <-- Info-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/Info.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Info.png,v <-- Info.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/jar.mn; /cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v <-- jar.mn new revision: 1.90; previous revision: 1.89 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/searchButtons-aero.png,v done Checking in browser/themes/winstripe/browser/searchButtons-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/searchButtons-aero.png,v <-- searchButtons-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/searchButtons.png,v done Checking in browser/themes/winstripe/browser/searchButtons.png; /cvsroot/mozilla/browser/themes/winstripe/browser/searchButtons.png,v <-- searchButtons.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/siteButtons-aero.png,v done Checking in browser/themes/winstripe/browser/siteButtons-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/siteButtons-aero.png,v <-- siteButtons-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/siteButtons.png,v done Checking in browser/themes/winstripe/browser/siteButtons.png; /cvsroot/mozilla/browser/themes/winstripe/browser/siteButtons.png,v <-- siteButtons.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/libraryToolbar-aero.png,v done Checking in browser/themes/winstripe/browser/places/libraryToolbar-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/libraryToolbar-aero.png,v <-- libraryToolbar-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/libraryToolbar.png,v done Checking in browser/themes/winstripe/browser/places/libraryToolbar.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/libraryToolbar.png,v <-- libraryToolbar.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/unsortedBookmarks-aero.png,v done Checking in browser/themes/winstripe/browser/places/unsortedBookmarks-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/unsortedBookmarks-aero.png,v <-- unsortedBookmarks-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/unsortedBookmarks.png,v done Checking in browser/themes/winstripe/browser/places/unsortedBookmarks.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/unsortedBookmarks.png,v <-- unsortedBookmarks.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png,v <-- tab-arrow-end.png new revision: 1.6; previous revision: 1.5 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png,v <-- tab-arrow-start.png new revision: 1.6; previous revision: 1.5 done Checking in toolkit/themes/winstripe/global/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v <-- jar.mn new revision: 1.52; previous revision: 1.51 done Checking in toolkit/themes/winstripe/global/console/console-toolbar.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/console-toolbar.png,v <-- console-toolbar.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/global/icons/close.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close.png,v <-- close.png new revision: 1.9; previous revision: 1.8 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebar-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/closeSidebar-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebar-aero.png,v <-- closeSidebar-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebar.png,v done Checking in toolkit/themes/winstripe/global/icons/closeSidebar.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebar.png,v <-- closeSidebar.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/find-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find-aero.png,v <-- find-aero.png new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/global/icons/find.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find.png,v <-- find.png new revision: 1.7; previous revision: 1.6 done Checking in toolkit/themes/winstripe/global/icons/folder-item-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/folder-item-aero.png,v <-- folder-item-aero.png new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/global/icons/folder-item.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/folder-item.png,v <-- folder-item.png new revision: 1.8; previous revision: 1.7 done Checking in toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png,v <-- ratings-aero.png new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/mozapps/extensions/ratings.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings.png,v <-- ratings.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/mozapps/profile/profileicon.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/profile/profileicon.png,v <-- profileicon.png new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
20080419_0357_firefox-3.0pre.en-US.win32.zip unsortedBookmarks.png closeSidebar.png these are not changed. intended ? http://img522.imageshack.us/img522/1866/0419ev2.jpg
(In reply to comment #8) > unsortedBookmarks.png > closeSidebar.png > these are not changed. intended ? Yeah, they are new icons. I just added them for future use. :)
(In reply to comment #5) > Created an attachment (id=316474) [details] > iconDrop for 2008-04-18 (take 2) careless mistake? specifications? Toolbar.png and Toolbar-small.png (Luna style icons) cut icon, copy icon, paste icon: usually -> bright hover -> normal other icons: usually -> normal hover -> bright
Attached image Screenshot (deleted) —
APNG Screenshot
reporter icon too (Luna style icons)
Alex, we talked about the new home button (to leave the house) in IRC. As I see now there wasn't an update. Will this be done with a further icon update?
The toolbar icons will land with bug 429688
Flags: blocking-firefox3? → blocking-firefox3+
Now that bug 429688 is WONTFIX, the toolbar icons should land (per comment 7). Right?
There were some changes to the position of the keyhole buttons since we modified the spacing slightly, fixed with bug 430384
Does that mean that the toolbar icons will be landing now?
(In reply to comment #13) > Alex, we talked about the new home button (to leave the house) in IRC. As I see > now there wasn't an update. Will this be done with a further icon update? Is it me or is the "Home" icon two px smaller then all other icons? Also, it's not centered on mouseover, it needs to move over 1px to the left. ~B
Looks like it landed without a further regression. I think the mentioned home icon issue was fixed by a follow-up icon landing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: