Alex to provide new dimensions and new Toolbar.png and Toolbar-areo.png files.

(toolbar-aero.png, even)

Dao, hopefully by the time you read this, Alex will have this stuff posted. Please request review from me, since I'm on EDT, and we're trying to wrap up as soon as possible, this is one of the last blockers.

Sadly, we got a broken delivery from the IconFactory. However, Alex tells me that he can assemble a Toolbar.png which we can check in and base CSS changes on, and then we can replace that with another one (he'll file a follow-up bug and nominate for blocking) when we get the fixes. Alex, can you post those new Toolbar.png and Toolbar-aero.png files ASAP so we can get the CSS part done?

These are unfortunately not the final files (drop marker is not disabled in the disabled states), however go ahead and land them with the css changes and we will refresh them with the next icon drop. The image regions will stay the same.

> Toolbar.png > Toolbar-small.png Bug 429689 comment #5 I do not understand why only cut, copy and paste icons are different behavior. Are there any guidelines?

I'm sorry. My wanting to say is this. Bug 429689 comment #10

AKIHIRO, please see comment 8 where Alex says these aren't the final images. I believe your comments will be addressed when we get all of those images.

Comment on attachment 317227 [details] [diff] [review] patch r+a=me, thanks!

mozilla/browser/themes/winstripe/browser/Toolbar-aero.png 1.6 mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png 1.4 mozilla/browser/themes/winstripe/browser/Toolbar-small.png 1.11 mozilla/browser/themes/winstripe/browser/Toolbar.png 1.12 mozilla/browser/themes/winstripe/browser/browser.css 1.206

(In reply to comment #12) > AKIHIRO, please see comment 8 where Alex says these aren't the final images. I > believe your comments will be addressed when we get all of those images. OK, and more, {Build ID: 2008042400} Toolbar.png (New tab, New Window) and Toolbar-small.png (Print, New tab, New Window). Mistake of arrangement

APNG Screenshot

Not sure if this is the right place to bring this up, but I personally have mixed feelings about the new toolbar icons. To avoid taking this off-topic, I'll just post a link: http://forums.mozillazine.org/viewtopic.php?p=3350238#3350238

Uhm, last icons look more bad IMHO, they are more dark than the previous. And the keyhole is more vertical unaligned now.

The aero small disabled forwards button got shifted 1px with this checkin: before: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/634491129642/browser/themes/winstripe/browser/Toolbar-small-aero.png after: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/8f8ce43692b4/browser/themes/winstripe/browser/Toolbar-small-aero.png

I cannot see any of these mentioned aligning issues. The keyhole looks good to me and even the disabled forward button is positioned correctly now with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050206 Minefield/3.0pre