The about:config content area message should use a 48x48 icon to match other content area warning messages. It is currently using a 32x32 icon. /winstripe/global/icons/warning-large-aero.png /winstripe/global/icons/warning-large.png

The problem was that the alert-icon style selected a smaller icon for the about:config page. This patch simply removes that class. Since no other rules are defined for the .alert-icon selector, this patch does not have any side effects.

Comment on attachment 316488 [details] [diff] [review] Patch (v1) Trying gavin for the review. Should be pretty easy to review.

Comment on attachment 316488 [details] [diff] [review] Patch (v1) This patch isn't as easy to review as you may think - the alert-icon styling across platforms is confusing, given that they're all different sizes (does the removal of those size restrictions mess up the display? what about the removal of the margins on pinstripe? hard to know without testing it). It's also not clear that the styling of #exclam in winstripe's config.css applies to Linux (gnomestripe doesn't override the file, so I assume it does).

Now that I think of it this way, you're right. It wasn't that easy! Anyway, thanks for the review. :-)

Comment on attachment 316488 [details] [diff] [review] Patch (v1) Requesting approval for this change to make the about:config dialog warning screen similar to the sibling screens in Firefox.

Comment on attachment 316488 [details] [diff] [review] Patch (v1) ... setting the flag this time!

Comment on attachment 316488 [details] [diff] [review] Patch (v1) a1.9=beltzner

mozilla/toolkit/components/viewconfig/content/config.xul 1.15

uh-oh !!!! I just upgraded to a Linux Tinderbox Build last night (this is in there, I think) and I'm not seeing ANY warning at all on Linux anymore. (Not upon tab pop-up, and not upon changing values, either.) Gavin, your comment 3 might be right-- I'll SWAG that Linux *is* effected, badly. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050520 Minefield/3.0pre - Build ID: 2008050520

WFM on Gecko/2008050604, Ubuntu 8.04. Perhaps you have general.warnOnAboutConfig set (to false) by unchecking the checkbox on the warning page?

YES -- I clicked early didn't engage brain until you reminded me. Sorry I SPAMmed the fixed bug, thanks.