Closed Bug 430449 Opened 17 years ago Closed 16 years ago

Notification button and close are misaligned

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: mossop, Assigned: mstange)

References

Details

(Keywords: polish, verified1.9.1)

Attachments

(3 files, 1 obsolete file)

screenie
(deleted), image/png
Details
better notification bar alignment
(deleted), image/png
faaborg
: ui-review+
Details
v2
(deleted), patch
dao
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
With the new mac theme updates the button and the close button on notification bars are poorly aligned.
Attached image screenie (deleted) —
Attached image better notification bar alignment (deleted) —
Attachment #339485 - Flags: ui-review?
Attachment #339485 - Flags: ui-review? → ui-review?(faaborg)
Attached patch fix rev1 (obsolete) (deleted) — — Splinter Review
Attachment #339487 - Flags: review?(mconnor)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Component: Theme → Themes
Keywords: polish
Product: Firefox → Toolkit
QA Contact: theme → themes
Hardware: PC → All
Blocks: 458197
Attached patch v2 (deleted) — — Splinter Review
Evil Dão keeps bitrotting my patches.
Attachment #339487 - Attachment is obsolete: true
Attachment #344123 - Flags: review?(rflint)
Attachment #339487 - Flags: review?(mconnor)
Attachment #339485 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 339485 [details] better notification bar alignment Really sorry about the lag, somehow this slipped through the cracks of my inbox. If you get the impression I forgot to do a review by all means bother me constantly until I review something :)
Attachment #344123 - Flags: review?(rflint) → review?(dao)
Attachment #344123 - Flags: review?(dao) → review-
Comment on attachment 344123 [details] [diff] [review] v2 I don't see a reason to move this stuff back into global.css.
Blocks: 462606
Attachment #344123 - Flags: review- → review+
Comment on attachment 344123 [details] [diff] [review] v2 Ok, so the usual question: are the two new !important flags really needed? > notification { >+ padding: 4px 3px 5px 3px; nit: 4px 3px 5px
(In reply to comment #8) > (From update of attachment 344123 [details] [diff] [review]) > Ok, so the usual question: are the two new !important flags really needed? In contrast to bug 231313, I think this time they are :) But I don't remember why, so I'll check again.
The easiest way to see the rules in the order they apply is (AFAIK) DOM Inspector's "Object - CSS Style Rules" view.
+notification > button { + -moz-appearance: none !important; This one isn't necessary. .notification-inner { border: 0 !important; This one is necessary because the element also has the class "outset" that gets a border from global.css. +.messageText { + margin: 0 3px !important; This is also necessary because global.css has a margin-bottom: 4px; rule for descriptions.
Attachment #344123 - Flags: approval1.9.1?
Comment on attachment 344123 [details] [diff] [review] v2 CSS-only polish, also fixes bug 462606.
Comment on attachment 344123 [details] [diff] [review] v2 a191=beltzner
Attachment #344123 - Flags: approval1.9.1? → approval1.9.1+
http://hg.mozilla.org/mozilla-central/rev/4ff260cb5fea
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Keywords: fixed1.9.1
Verified fixed on 1.9.1 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: