Dão Gottwald [:dao] Assignee
	Description • 16 years ago

This started as a simple "merge formatting.css into global.css" task. But there's so much junk in there, especially in pinstripe, that it got rather complex.

The patch does:

1. merge formatting.css into global.css
2. remove stuff that's obsolete and unused:
     [wait-cursor]
     .toolbar-focustarget
     .box-inset
     .groove-top
     .groove-right
     .groove-left
     .groove-bottom
     .outset-top-bottom
     separator.groove-thin
     .header
     .larger-text
     .smaller-text
3. move stuff from global.css to more appropriate stylesheets
4. add comments for stuff that looks wrong and should be (re)moved
5. fix rtl support
6. fix other bugs like #foo.bar -> #foo\.bar if the id is "foo.bar"

	Dão Gottwald [:dao] Assignee
	Comment 1 • 16 years ago

(In reply to comment #0)
> 2. remove stuff that's obsolete and unused:

more:

#warn1
#header

	neil@parkwaycc.co.uk
	Comment 2 • 16 years ago

(In reply to comment #0)
>      .toolbar-focustarget
Still used in editor/message compose; feel free to suggest a replacement.

>      .outset-top-bottom
Used in suite, apparently, but we can probably move or remove it.

>      .header
Still used in toolkit!

	Dão Gottwald [:dao] Assignee
	Comment 3 • 16 years ago

(In reply to comment #2)
> >      .toolbar-focustarget
> Still used in editor/message compose; feel free to suggest a replacement.

Could probably just inline style="-moz-user-focus:ignore", but added back for now.

> >      .outset-top-bottom
> Used in suite, apparently, but we can probably move or remove it.

This can be added to search.css if wanted. I'll file a bug.

> >      .header
> Still used in toolkit!

added back

	neil@parkwaycc.co.uk
	Comment 4 • 16 years ago

Comment on attachment 342711 [details] [diff] [review]
patch v2

>-.message-icon,
>+.message-icon {
>+  display: none;
>+}
Why this change?

>+description,
>+label {
>+  cursor: default;
>+}
>+
>+label {
>+  margin-top: 1px;
>+  margin-bottom: 2px;
>+  -moz-margin-start: 6px;
>+  -moz-margin-end: 5px;
>+}
No margins for the description?

>+/* ??? */
>+browser {
>+  background-color: #fff;
>+}
Any CVS history for this perhaps? Might as well leave it out otherwise.

>+notification > button {
As this is in notification.css these styles will only apply to anonymous buttons inside the notification anyway, so that the child selector is superfluous.

	Dão Gottwald [:dao] Assignee
	Comment 5 • 16 years ago

(In reply to comment #4)
> (From update of attachment 342711 [details] [diff] [review])
> >-.message-icon,
> >+.message-icon {
> >+  display: none;
> >+}
> Why this change?

Not a change... there's a display:none for .message-icon below in the current glogal.css.

> >+description,
> >+label {
> >+  cursor: default;
> >+}
> >+
> >+label {
> >+  margin-top: 1px;
> >+  margin-bottom: 2px;
> >+  -moz-margin-start: 6px;
> >+  -moz-margin-end: 5px;
> >+}
> No margins for the description?

I don't know if this is intentional, but it's what the current formatting.css does.

> >+/* ??? */
> >+browser {
> >+  background-color: #fff;
> >+}
> Any CVS history for this perhaps? Might as well leave it out otherwise.

"1.2 <ben@bengoodger.com> 2004-06-18 14:06
More Winstripe/Pinstripe Restructuring"

:(

	Dão Gottwald [:dao] Assignee
	Comment 6 • 16 years ago

(In reply to comment #4)
> >+/* ??? */
> >+browser {
> >+  background-color: #fff;
> >+}
> Any CVS history for this perhaps? Might as well leave it out otherwise.

removed

> >+notification > button {
> As this is in notification.css these styles will only apply to anonymous
> buttons inside the notification anyway, so that the child selector is
> superfluous.

removed "notification >"

I also removed .messageButton from notification.css.

	neil@parkwaycc.co.uk
	Comment 7 • 16 years ago

Comment on attachment 342762 [details] [diff] [review]
patch v3

The old (Moz/SeaMonkey) Mac Classic formatting.css gave description a margin since before it was even called description, so I think it at least needs a bug ;-)

	Dão Gottwald [:dao] Assignee
	Comment 8 • 16 years ago

(In reply to comment #3)
> > >      .outset-top-bottom
> > Used in suite, apparently, but we can probably move or remove it.
> 
> This can be added to search.css if wanted. I'll file a bug.

filed bug 459564

(In reply to comment #7)
> The old (Moz/SeaMonkey) Mac Classic formatting.css gave description a margin
> since before it was even called description, so I think it at least needs a bug
> ;-)

filed bug 459563

	Dão Gottwald [:dao] Assignee
	Comment 9 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/61021ed80a2e

	Markus Stange [:mstange]
	Comment 10 • 16 years ago

Moving the Pinstripe notification bar button styles to notification.css didn't really work - the button isn't anonymous XBL content, so notification.css doesn't apply to it. I'm moving the rule back in bug 430449.

	Neil Deakin
	Comment 11 • 16 years ago

> 2. remove stuff that's obsolete and unused:
>      [wait-cursor]
>      .toolbar-focustarget
>      .box-inset
>      .groove-top
>      .groove-right
>      .groove-left
>      .groove-bottom
>      .outset-top-bottom
>      separator.groove-thin
>      .header
>      .larger-text
>      .smaller-text

That's incorrect. Many of those are documented as being available ( at http://www.xulplanet.com/references/elemref/ref_XULElement.html , https://developer.mozilla.org/en/XUL/Style and others) and thus classify as 'used'.

	Dão Gottwald [:dao] Assignee
	Comment 12 • 16 years ago

header wasn't removed, so this leaves groove-thin on DevMo, as far as I can see. Xulplanet is outdated anyway, right?