Closed
Bug 430907
Opened 17 years ago
Closed 17 years ago
Refresh flexible space icon in the toolbar customization palette (Windows, Linux)
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: faaborg, Assigned: ehsan.akhgari)
References
Details
Attachments
(3 files, 2 obsolete files)
(deleted),
image/png
|
faaborg
:
ui-review+
beltzner
:
approval1.9+
|
Details |
(deleted),
image/svg+xml
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Bug 430759 will land new icons to be used for "flexible space" in the toolbar customization palette on XP and Vista:
toolkit/themes/winstripe/global/toolbar/spring-aero.png
toolkit/themes/winstripe/global/toolbar/spring.png
if the tango theme would like to refresh this icon as well it should be placed in a similar location in gnomestripe. A small amount of work is required for this update since the current file is a gif, and the new file a png.
Assignee | ||
Comment 1•17 years ago
|
||
Simple patch.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #317852 -
Flags: review?(gavin.sharp)
Comment 2•17 years ago
|
||
Comment on attachment 317852 [details] [diff] [review]
Patch (v1)
spring.png/spring-aero.png haven't landed yet, and you'll need to also changes gnomestripe's toolbar.css to avoid breaking it.
Attachment #317852 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Comment 3•17 years ago
|
||
> spring.png/spring-aero.png haven't landed yet
Yes, they'll land in bug 430759, which is a dependency of this bug. I'll request check-in on this bug after the icons land in bug 430759.
> and you'll need to also changes
> gnomestripe's toolbar.css to avoid breaking it.
Done.
Attachment #317920 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•17 years ago
|
Whiteboard: [bug 430759 should land before this bug]
Assignee | ||
Updated•17 years ago
|
Whiteboard: [bug 430759 should land before this bug]
Comment 4•17 years ago
|
||
Comment 5•17 years ago
|
||
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 318113 [details]
source SVG for tweaking
Does this have/need approval?
Assignee | ||
Updated•17 years ago
|
Whiteboard: [has patch] [needs review gavin]
Updated•17 years ago
|
Attachment #318112 -
Flags: ui-review?(faaborg)
Reporter | ||
Updated•17 years ago
|
Attachment #318112 -
Flags: ui-review?(faaborg) → ui-review+
Updated•17 years ago
|
Attachment #318112 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #318112 -
Flags: approval1.9? → approval1.9+
Comment 7•17 years ago
|
||
Comment on attachment 317920 [details] [diff] [review]
Patch (v1.1)
>Index: toolkit/themes/winstripe/global/jar.mn
>- skin/classic/global/toolbar/spring.gif (toolbar/spring.gif)
>+ skin/classic/global/toolbar/spring.png (toolbar/spring.png)
Let's just add the .png and keep the .gif in case there are existing toolkit users (probably unlikely, but doesn't really hurt at this point).
Looks like the addition of the png to this jar.mn already landed as part of the icon drop, so no need to make any changes to jar.mn.
Attachment #317920 -
Flags: review?(gavin.sharp) → review+
Updated•17 years ago
|
Attachment #317920 -
Flags: approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch] [needs review gavin] → [has patch]
Comment 8•17 years ago
|
||
Jakub, nice, btw can you round up the arrows a bit, so we don't end up with those too dark corners?
Comment 9•17 years ago
|
||
This is what I landed.
mozilla/toolkit/themes/gnomestripe/global/jar.mn 1.42
mozilla/toolkit/themes/gnomestripe/global/toolbar.css 1.15
mozilla/toolkit/themes/gnomestripe/global/toolbar/spring.png 1.1
mozilla/toolkit/themes/winstripe/global/toolbar.css 1.20
Attachment #317852 -
Attachment is obsolete: true
Attachment #317920 -
Attachment is obsolete: true
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3
You need to log in
before you can comment on or make changes to this bug.
Description
•