Carried over from bug 430908 ... Alex to add dependencies and details about what this will fix. A lot of polish to be done here.

here is the drop: http://people.mozilla.com/~faaborg/files/granParadisoUI/icons/iconDrop-20080429.zip This includes -theme preview image -added search close to toolkit -added 16x16 plugin icon to toolkit -added rtl vista tree view icons to toolkit -revised local directory listing favicons to be hard drives instead of folders -added white close buttons for use on notification bars We still need to figure out what to do with open search discovery.

a=beltzner for 1.9

What's the status on landing this?

(In reply to comment #1) > -added 16x16 plugin icon to toolkit > Is this replacing or supplementing the ones in *stripe/browser/preferences? (or more to the point, does this entail any changes to the app handlers preference pane?)

>does this entail any changes to the app handlers preference pane? No, all of those icons remain the same in this drop.

(In reply to comment #3) > What's the status on landing this? I have questions for you before I landed this. I've been trying to find you. :) However, I don't have time to land this tonight. First chance I'll have is tomorrow afternoon/evening. If that's ok, then I'll do it then. Otherwise, I guess Gavin could land it, and I can follow-up later with the issues I found.

The sooner we get these checked in, the sooner our beta testers can start to find off by one issues and we can get them corrected.

Removing browser/themes/winstripe/browser/Search-close-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-close-aero.png,v <-- Search-close-aero.png new revision: delete; previous revision: 1.1 done Removing browser/themes/winstripe/browser/Search-close.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-close.png,v <-- Search-close.png new revision: delete; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/jar.mn; /cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v <-- jar.mn new revision: 1.95; previous revision: 1.94 done Checking in toolkit/themes/winstripe/global/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v <-- jar.mn new revision: 1.57; previous revision: 1.56 done Checking in toolkit/themes/winstripe/global/dirListing/local-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/local-aero.png,v <-- local-aero.png new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/global/dirListing/local.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/local.png,v <-- local.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Search-close-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/Search-close-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Search-close-aero.png,v <-- Search-close-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Search-close.png,v done Checking in toolkit/themes/winstripe/global/icons/Search-close.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Search-close.png,v <-- Search-close.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/blacklist_favicon.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/blacklist_favicon.png,v <-- blacklist_favicon.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/icons/closeSidebar.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebar.png,v <-- closeSidebar.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebarWhite-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/closeSidebarWhite-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebarWhite-aero.png,v <-- closeSidebarWhite-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebarWhite.png,v done Checking in toolkit/themes/winstripe/global/icons/closeSidebarWhite.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/closeSidebarWhite.png,v <-- closeSidebarWhite.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-clsd-hover-rtl-aero.png,v done Checking in toolkit/themes/winstripe/global/tree/twisty-clsd-hover-rtl-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-clsd-hover-rtl-aero.png,v <-- twisty-clsd-hover-rtl-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-clsd-rtl-aero.png,v done Checking in toolkit/themes/winstripe/global/tree/twisty-clsd-rtl-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-clsd-rtl-aero.png,v <-- twisty-clsd-rtl-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-open-hover-rtl-aero.png,v done Checking in toolkit/themes/winstripe/global/tree/twisty-open-hover-rtl-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-open-hover-rtl-aero.png,v <-- twisty-open-hover-rtl-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-open-rtl-aero.png,v done Checking in toolkit/themes/winstripe/global/tree/twisty-open-rtl-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/tree/twisty-open-rtl-aero.png,v <-- twisty-open-rtl-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v <-- jar.mn new revision: 1.36; previous revision: 1.35 done Checking in toolkit/themes/winstripe/mozapps/passwordmgr/key-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/passwordmgr/key-aero.png,v <-- key-aero.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/mozapps/passwordmgr/key.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/passwordmgr/key.png,v <-- key.png new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16-aero.png,v <-- pluginGeneric-16-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16.png,v done Checking in toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16.png,v <-- pluginGeneric-16.png initial revision: 1.1 done

Reed, could you please list the issues you had in this bug? I'm not sure why those are reserved for Alex-over-IM-only.

The issues were: browser/themes/winstripe/browser/places/placesIcon.png I switched this icon to the updated star out of fear of it actually being used somewhere (this used to be http://mxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/places/placesIcon.png), the file has been removed. Serch-close.png and Search-close-aero.png were removed from browser since they are now also in toolkit. toolkit/themes/winstripe/global/tree/, *-aero-rtl.png should be -rtl-aero.png, these files have been renamed.