Closed Bug 434252 Opened 17 years ago Closed 16 years ago

Mishandling of URL encoding of symbols (e.g. %20) when performing a locale redirection

Categories

(addons.mozilla.org Graveyard :: Localization, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mike.kenyon, Assigned: oremj)

References

Details

(Whiteboard: [bug morphed in comment #3])

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9) Gecko/2008051206 Firefox/3.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9) Gecko/2008051206 Firefox/3.0 In the add-on manager, encoded in URLs, when deciding to "See all results" after searching for an add-on, if the search query has a non-alphanumeric character which must be specially escaped (e.g. %20 for a space), the corresponding webpage at addons.mozilla.org does not re-convert the escaped character to its proper ASCII/Unicode character, but leaves it as the escaped value. Reproducible: Always Steps to Reproduce: 1. Open the Add-On Manager 2. Click the Get Add-Ons tab 3. Search for "Stumble upon", for example, or any query with a non-alphanumeric character 4. Choose to "See all results (11)" 5. Be told that "stumble%20upon" has no results. Actual Results: See: https://addons.mozilla.org/en-US/firefox/search?q=stumble%2520upon Expected Results: See: https://addons.mozilla.org/en-US/firefox/search?q=stumble+upon&cat=all
WFM using: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008051703 Minefield/3.1a1pre Firefox/3.0 ID:2008051703 Fixed by: https://bugzilla.mozilla.org/show_bug.cgi?id=404024
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Works: en-US Broken: en-GB Haven't tried other locales. Bug 404024 is a the general bug for adding the AMO integration, so I think it's probably best to reopen this and have it block that instead.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Version: unspecified → 3.0 Branch
Blocks: 404024
Status: UNCONFIRMED → NEW
Ever confirmed: true
The en-GB locale doesn't exist at addons.mozilla.org, so all en-GB addresses are automatically redirected to en-US. The redirection at AMO is the culprit: it should either decode the input URI before encoding or not attempt to encode at all. Works: https://addons.mozilla.com/en-US/firefox/search?q=url%20flipper Broken: https://addons.mozilla.com/en-GB/firefox/search?q=url%20flipper This affects any locale that is subject to a redirect. Firefox provides the locale name when directing users to AMO with the "see all results" feature, and since there are many Firefox locales that are not represented by AMO, this bug's impact is fairly wide. To make matters worse, the %-encoded characters that this breaks are much more important for non-English locales.
Severity: minor → major
Component: Extension/Theme Manager → Localization
Product: Firefox → addons.mozilla.org
QA Contact: extension.manager → l10n
Whiteboard: [see comment #3]
Version: 3.0 Branch → unspecified
OS: Windows Vista → All
Hardware: PC → All
Summary: Mishandling of URL encoding of symbols (e.g. %20) when seeing all results of add-ons searched for through Fx → Mishandling of URL encoding of symbols (e.g. %20) when performing a locale redirection
Version: unspecified → 3.2
Whiteboard: [see comment #3] → [bug morphed in comment #3]
Looks somewhat similar to bug 414595
I would say related, but not similar. The problem is not that the queries are over-escaped as per 414595, but rather that they are not decoded back into symbols.
There are some subtle differences in all the URLs here but the only thing I can reproduce at this point is the problem in comment 3 which is going to addons.mozilla.*com*. Since the problem appears to happen in the .com -> .org redirect I'm reassigning to oremj.
Assignee: nobody → oremj
This is fixed and the fix will be live within the hour.
Status: NEW → RESOLVED
Closed: 17 years ago16 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.