Closed Bug 43490 Opened 24 years ago Closed 24 years ago

textfields, tooltips and context menus have window's default bg color and font

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: doronr, Assigned: attinasi)

References

Details

(Keywords: regression, Whiteboard: [nsbeta2+])

Attachments

(1 file)

Patch to disable style context data sharing and fix the problem...
(deleted), patch
Details | Diff | Splinter Review
the url bar, tooltips, and some form controls have the default windows background color. context menu too.
reassigning to ben, this applies to context menus also
Assignee: trudelle → ben
Severity: major → normal
Summary: xul textarea have window's default bg color → tooltips and context menus have window's default bg color
now that's interesting... cc'ing pink who works on da menus.
small subject change to add textfields too.
Summary: tooltips and context menus have window's default bg color → textfields, tooltips and context menus have window's default bg color
*** Bug 43917 has been marked as a duplicate of this bug. ***
*** Bug 43917 has been marked as a duplicate of this bug. ***
*** Bug 43917 has been marked as a duplicate of this bug. ***
Crap, sorry for the spam (something seems to be broken with form submission today, i'm adding this comment with Navigator). 43917 points out something I should have added to this bug earlier; the font is wrong. In my case it's Arial instead of Trebuchet.
*** Bug 43917 has been marked as a duplicate of this bug. ***
*** Bug 43917 has been marked as a duplicate of this bug. ***
I'm almost positive this was caused by my recent checkin of some new code to reduce the size of the style system by sharing style context data. Disabling that code makes this bug go away. Taking this over to backout the change...
Assignee: ben → attinasi
Updated summary to include font problems.
Status: NEW → ASSIGNED
Summary: textfields, tooltips and context menus have window's default bg color → textfields, tooltips and context menus have window's default bg color and font
*** Bug 43862 has been marked as a duplicate of this bug. ***
One line patch to disable style data sharing fixes this problem. I recommend we disable the sharing until I can determine why XUL elements are not styling properly.
Severity: normal → major
Keywords: nsbeta2, regression
OS: Windows 98 → All
Hardware: PC → All
*** Bug 44030 has been marked as a duplicate of this bug. ***
PDT: can we get this patch checked in? This regression makes it really difficult to use our UI in the following ways: * can't edit text since the text is drawn in one size and measured in another * text is too large; hard to see everything without scrolling both horizontally and vertically * hard to select text with the background color since that interferes with the system selection colors * other UI elements are also impacted
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: [nsbeta2+]
Keywords: approval, review
Fixed. Turned off sharing in nsStyleContext.cpp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Depends on: 39618
verified fixed (turned off) in mac/linux/win32 2000063008/9 build.
Status: RESOLVED → VERIFIED
*** Bug 43685 has been marked as a duplicate of this bug. ***
*** Bug 44325 has been marked as a duplicate of this bug. ***
*** Bug 44550 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: