Closed
Bug 437358
Opened 16 years ago
Closed 16 years ago
Use native platform colors for URLs in the location bar autocomplete
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 3.1a2
People
(Reporter: akavoor, Assigned: dao)
References
Details
Attachments
(3 files, 1 obsolete file)
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008050509 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008050509 Firefox/3.0b5
Beta versions had a green- white color scheme in location bar. this was too good.
The location bars in RC has a white-white color scheme which is bad. Please change it.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1•16 years ago
|
||
what theme are you using ?
Reporter | ||
Comment 2•16 years ago
|
||
I am using the default Ubuntu Human theme.
Here is a acreenshot. See the difference between the Beta5 version and RC2 version.
http://img357.imageshack.us/my.php?image=screenda2.jpg
Updated•16 years ago
|
Whiteboard: dupeme
Updated•16 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 4•16 years ago
|
||
Bug 409974 was about the use of hard coded colors, which caused problems with certain OS themes. That bug is fixed now. GrayText isn't ideal, though, so this bug is still valid and not a duplicate.
Status: RESOLVED → UNCONFIRMED
Component: Location Bar and Autocomplete → Theme
Depends on: 426732
Resolution: DUPLICATE → ---
Whiteboard: dupeme
Version: unspecified → Trunk
Assignee | ||
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 5•16 years ago
|
||
Comment 6•16 years ago
|
||
If you prefer the old appearance, you can use the following userChrome (see http://support.mozilla.com/en-US/kb/Editing+configuration+files#userChrome_css for instructions):
.ac-url-text {
color: #336633 !important;
}
.autocomplete-richlistitem {
border-bottom: 1px solid ThreeDShadow !important;
}
(this is from bug 409974 comment 35)
Updated•16 years ago
|
QA Contact: location.bar → theme
Reporter | ||
Comment 7•16 years ago
|
||
I added the code to userchrome.css which indeed gave me what I needed. But I have one problem in that.
When the mouse moves over a particular website in the location bar drop down menu, both the website title and the website address should change color to black there by making it different from the rest.
Assignee | ||
Comment 9•16 years ago
|
||
Note that -moz-nativehyperlinktext falls back to #144fae on OS X.
Assignee | ||
Updated•16 years ago
|
OS: Linux → All
Hardware: PC → All
Summary: No good color scheme in location bar → Use native platform colors for URLs in the location bar autocomplete
Comment 10•16 years ago
|
||
Note that on Vista it was decided in Bug 432757 to use a darker than normal color for .ac-url-text. We might want to leave some of the windows-default-theme fu in there for that. Beltzner?
Assignee | ||
Comment 11•16 years ago
|
||
Umm, yeah, I expected such things but forgot about that particular bug.
FWIW: We now have the native color that we were trying to hardcode and we should use it unless the native color is broken somehow. Making a native color slightly darker doesn't seem like a proper use case for windows-default-theme. See bug 426660 comment 25. See also bug 431666 comment 5.
Assignee | ||
Comment 12•16 years ago
|
||
Talked to beltzner, on XP we're going to stick with green for now.
Attachment #329283 -
Attachment is obsolete: true
Attachment #331900 -
Flags: review?(gavin.sharp)
Attachment #329283 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #331900 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 13•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Verified FIXED using:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre
on:
mozilla@mozilla-qa:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 8.04.1
Release: 8.04
Codename: hardy
with Human, Mist, Clearlooks, Crux, etc. (in all cases, the URL, as well as the other elements in the location bar, was easy to read, even with the High Contrast themes).
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre
Default Windows XP theme has URLs in green; "Windows Classic" returns the URLs' colors to blue.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre
Vista's default URL color is blue, and again, "Windows Classic" returns the URLs' colors to blue.
And, finally, on both XP and Vista, I spot-checked high-contrast color schemes, and we respected (and reflected) the color schemes there.
Status: RESOLVED → VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre should be the last build ID, sorry.
See Also: → https://launchpad.net/bugs/238823
You need to log in
before you can comment on or make changes to this bug.
Description
•