Closed Bug 443493 Opened 16 years ago Closed 16 years ago

Unit test for Bug 331215 fails rather frequently on Mozilla2 builds

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: mtschrep, Assigned: sdwilsh)

References

Details

(Keywords: fixed1.9.0.2)

Attachments

(1 file)

Both centos machines fail a few times a day on this test: http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla2/1215070076.1215075802.8487.gz&fulltext=1 Looking at the testcase there is a setTimeout in there: https://bugzilla.mozilla.org/attachment.cgi?id=255989&action=diff Would like to remove that dependency or up the timeout to try and increase the reliability of this test.
Blocks: 442169
Attached patch v1.0 (deleted) — Splinter Review
Test runs noticeably faster locally too.
Attachment #328038 - Flags: review?(mconnor)
Comment on attachment 328038 [details] [diff] [review] v1.0 We should also get this on the branch for those tests.
Attachment #328038 - Flags: review?(mconnor)
Attachment #328038 - Flags: review+
Attachment #328038 - Flags: approval1.9.0.2+
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/7392f9bdbea8 And to CVS: Checking in toolkit/content/tests/chrome/bug331215_window.xul; new revision: 1.2; previous revision: 1.1
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a1
So far, looks like the new version has only failed one of three runs on mozilla-central qm-centos5-03, only one of three on qm-centos5-moz2-01, and only two of four on cn-sea-qm-centos5-01. Is that better than before?
Ugh. Is it failing in a different manner?
Inconveniently enough, someone seems to have disappeared the past for the mozilla-central boxes, but my memory of them was that they were just like the SeaMonkey box's ongoing failure, "*** 455 ERROR FAIL | Findfield status attribute should have been 'notfound' after entering ltest | | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_bug331215.xul"
The failure before was a timeout, so that's something new. New bug please?
Blocks: 443763
If it turns out that all this "oh, can you file that bug for me?" stuff is because filing bugs costs money, and the bills only go out every eight years, I'm gonna be testy. Bug 443763.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: