Closed
Bug 443763
Opened 16 years ago
Closed 12 years ago
Unit test for Bug 331215 fails rather frequently on Mozilla2 builds (and nearly constantly on SeaMonkey builds)
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: philor, Assigned: philor)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #443493 +++
*** 495 ERROR FAIL | Unable to restore focus, expect failures and timeouts. | | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_bug331215.xul
*** 496 ERROR FAIL | Findfield status attribute should have been 'notfound' after entering ltest | | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_bug331215.xul
*** 500 ERROR FAIL | Unable to restore focus, expect failures and timeouts. | | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_bug360437.xul
Comment 1•16 years ago
|
||
Mano sending your way since you are the original author of the test. Just failed again today:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1215472662.1215478327.30044.gz&fulltext=1
Can you take a look?
Assignee: nobody → mano
Comment 2•16 years ago
|
||
If Mano can't, I can spend some time this week on it (ideally, not tomorrow though since my plate is pretty full atm)
Comment 4•16 years ago
|
||
Mano any progress? Can we just disable this until we get it stable?
Comment 5•16 years ago
|
||
Comment 6•16 years ago
|
||
Pushed disabling patch to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/b1b140485f13
Comment 7•16 years ago
|
||
Could you please also check this into 1.9.0 for the moment? The nearly constant SeaMonkey failures are on cvs trunk.
Comment 8•16 years ago
|
||
Yes - sorry. Meant to do that and got sidetracked.
Checking in toolkit/content/tests/chrome/test_bug331215.xul;
new revision: 1.2; previous revision: 1.1
Updated•16 years ago
|
Attachment #329138 -
Attachment description: disable the test for now → disable the test for now
[Checkin: Comment 6 & 8]
Updated•16 years ago
|
Product: Firefox → Toolkit
Comment 9•16 years ago
|
||
Found this while trying to sort out what rand-o-orange bugs are still valid or are now fixed.
So if I read this correctly, this test was disabled seven months ago in July2008. Whats left to do here?
- write new test, and enable it?
- fix & reenable test?
- fix code & then reenable test?
- something else?
Updated•16 years ago
|
Whiteboard: [orange]
Comment 10•16 years ago
|
||
(In reply to comment #9)
> Found this while trying to sort out what rand-o-orange bugs are still valid or
> are now fixed.
>
> So if I read this correctly, this test was disabled seven months ago in
> July2008. Whats left to do here?
> - write new test, and enable it?
> - fix & reenable test?
> - fix code & then reenable test?
> - something else?
Mano/sdwilsh: gentle ping?
Comment 11•16 years ago
|
||
(In reply to comment #10)
> Mano/sdwilsh: gentle ping?
I don't really know this code, but I could probably fix it.
Comment 12•16 years ago
|
||
Attachment #369536 -
Flags: review?(sdwilsh)
Comment 13•16 years ago
|
||
Comment on attachment 369536 [details] [diff] [review]
(Bv1) Add |todo(false, ...)|
[Checkin: Comment 14 & 15]
I am not an appropriate peer for this
Attachment #369536 -
Flags: review?(sdwilsh) → review?(gavin.sharp)
Updated•16 years ago
|
Attachment #369536 -
Flags: review?(gavin.sharp) → review+
Updated•16 years ago
|
Attachment #369536 -
Attachment description: (Bv1) Add |todo(false, ...)| → (Bv1) Add |todo(false, ...)|
[Checkin: Comment 14]
Comment 14•16 years ago
|
||
Comment on attachment 369536 [details] [diff] [review]
(Bv1) Add |todo(false, ...)|
[Checkin: Comment 14 & 15]
http://hg.mozilla.org/mozilla-central/rev/994e072144e9
Updated•16 years ago
|
Whiteboard: [orange] → [test currently disabled] [orange]
Comment 15•16 years ago
|
||
Comment on attachment 369536 [details] [diff] [review]
(Bv1) Add |todo(false, ...)|
[Checkin: Comment 14 & 15]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/360a6a54de86
Attachment #369536 -
Attachment description: (Bv1) Add |todo(false, ...)|
[Checkin: Comment 14] → (Bv1) Add |todo(false, ...)|
[Checkin: Comment 14 & 15]
Updated•16 years ago
|
Whiteboard: [test currently disabled] [orange] → [test currently disabled] [fixed1.9.1b4: Bv1] [orange]
Updated•16 years ago
|
Assignee | ||
Comment 16•12 years ago
|
||
Harness changes, widget changes, slave changes, overall speed improvement, I got zero failures on 10 runs on try. Reenabled in http://hg.mozilla.org/integration/mozilla-inbound/rev/95619df80315
Assignee: mano → philringnalda
Whiteboard: [test currently disabled] [fixed1.9.1b4: Bv1] [orange] → [orange]
Comment 17•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•