Closed Bug 449317 Opened 16 years ago Closed 16 years ago

Use the new search textbox binding in the Add-ons manager

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1a2

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

patch, without persisting the value
(deleted), patch
mossop
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) (deleted) — — Splinter Review
Btw, I don't think we should be persisting the value. I find this quite irritating every time I open the Add-ons manager after searching. We're not doing this for any other search field.
Attachment #332465 - Flags: review?(dtownsend)
AFAIR there was already a bug about this issue which was fixed. No idea why that still happens.
Dao, can we do something with bug 419185?
Blocks: 419185
(In reply to comment #0) > Btw, I don't think we should be persisting the value. I find this quite > irritating every time I open the Add-ons manager after searching. We're not > doing this for any other search field. Should file a bug on that (assuming there isn't one). It was one of the explicit requests from UX, but we can revisit it now. I should get to the patch some time this week.
(In reply to comment #3) > (In reply to comment #0) > > Btw, I don't think we should be persisting the value. I find this quite > > irritating every time I open the Add-ons manager after searching. We're not > > doing this for any other search field. > > Should file a bug on that (assuming there isn't one). It was one of the > explicit requests from UX, but we can revisit it now. It's bug 414791.
Blocks: 414791
Comment on attachment 332465 [details] [diff] [review] patch I'll post a new patch without persisting the value, as this allows me to actually change less code.
Attachment #332465 - Attachment is obsolete: true
Attachment #332465 - Flags: review?(dtownsend)
Just removing persist="value" wasn't enough; if there's any stored value, that will always be restored. I think the easiest solution is to use a different id for the textbox.
Attachment #332594 - Flags: review?(dtownsend)
Blocks: 414617
Comment on attachment 332594 [details] [diff] [review] patch, without persisting the value Looks excellent, thanks
Attachment #332594 - Flags: review?(dtownsend) → review+
http://hg.mozilla.org/index.cgi/mozilla-central/rev/1434eaf5a557
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080808020649 Minefield/3.1a2pre.
Status: RESOLVED → VERIFIED
To have a consistent look on OS X we should try to drive bug 449465 forward. Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080808031528 Minefield/3.1a2pre ID:20080808031528
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: