Closed Bug 451812 Opened 16 years ago Closed 16 years ago

Buildbotcustom should not specify --appname for Mochitests

Categories

(Release Engineering :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file)

Attached patch Fix (deleted) — Splinter Review
Buildbotcustom should not specify --appname for its mochitest runs, we do not really need to pass it in, and it will assist other applications by not requiring them to specify a whole new command entry for the mochi's.
Attachment #335146 - Flags: review?(ted.mielczarek)
As a followup to that, we could probably kill the platform-specific variants of those steps, as only the syntax/path of the command is different anyway. Note that this is one change I already have made for SeaMonkey from the beginning, so only MoCo users need to get fixed for that.
Attachment #335146 - Flags: review?(ted.mielczarek) → review+
$ cvs ci tools/buildbotcustom/unittest/steps.py                               
Checking in tools/buildbotcustom/unittest/steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v  <--  steps.py
new revision: 1.13; previous revision: 1.12
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> As a followup to that, we could probably kill the platform-specific variants of

I filed bug 456281.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: