Closed
Bug 455942
Opened 16 years ago
Closed 16 years ago
Port to comm-central: bug 440714, bug 447642, bug 454391, bug 454786, bug 454192
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(2 files)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
I worked through recent changes to the mozilla-central build system and it looks like the following affect us and should be ported to comm-central:
Bug 440714 use -xldscope for Sun Studio on Solaris
bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS.
Bug 454391 - Building of Qt port for N810 is failed.
Bug 454786 - Configuration Changes to allow WinCE resource and assembly compiling
Bug 454192 - firefox-bin doesn't use jemalloc on linux/solaris
Assignee | ||
Comment 1•16 years ago
|
||
The actual patch looks quite small for that list of bugs :)
We didn't have a jemalloc define in Makefiles for our apps at all yet but I suspect we actually want it.
Attachment #339330 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•16 years ago
|
||
More to come in a second patch:
http://hg.mozilla.org/mozilla-central/rev/7e95620116b1 (seems to lack a bug number)
Remove the v1 string ABI compatibility hacks. Replace references of nsTAString_CharT with nsTSubstring_CharT which is the new base class
bug 439050, change the build hooks from make-jars.pl over to JarMaker.py
Assignee | ||
Comment 3•16 years ago
|
||
this second patch adds the mentioned additional ports.
Attachment #339514 -
Flags: review?(bugzilla)
Updated•16 years ago
|
Attachment #339330 -
Flags: review?(bugzilla) → review+
Comment 4•16 years ago
|
||
Comment on attachment 339330 [details] [diff] [review]
patch for all those ports
I've not tested these, but they look fine. You missed mentioning bug 432917 in your list!
r=me
Comment 5•16 years ago
|
||
Comment on attachment 339514 [details] [diff] [review]
step 2: bug 439050, kill string v1 ABI
Again, not tested but looks fine. r=me.
Thanks for doing these.
Attachment #339514 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/bfb8c7673e81 and http://hg.mozilla.org/comm-central/rev/c59aa3774d43 - more is to come in yet another bug, I'm currently at another 13 diffs to look into if/how they affect us...
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•