Closed
Bug 458988
Opened 16 years ago
Closed 16 years ago
The 'suite' tests are not run anymore
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Blocks 1 open bug, )
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
(I initially noticed it on my local build: 'browser' tests number drop to 51 from 82.
Same with all 3 tinderboxes.)
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1223131010.1223135542.23152.gz&fulltext=1
Linux comm-central dep unit test on 2008/10/04 07:36:50
{
chrome://mochikit/content/browser/suite/modules/test/browser_sanitizer.js
TEST-PASS | chrome://mochikit/content/browser/suite/modules/test/browser_sanitizer.js | Sanitizer module imported
...
}
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1223135838.1223140368.6287.gz&fulltext=1
Linux comm-central dep unit test on 2008/10/04 08:57:18
http://mxr.mozilla.org/comm-central/source/suite/modules/test/browser_sanitizer.js
is not run anymore.
Regression timeframe:
http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-10-04+02%3A50%3A03&enddate=2008-10-04+08%3A54%3A19
Assignee | ||
Comment 1•16 years ago
|
||
The 'Chrome' tests regressed too: 5311 -> 825.
Severity: normal → major
Summary: browser_sanitizer.js is not run anymore → The 'suite' tests are not run anymore
Assignee | ||
Updated•16 years ago
|
Comment 2•16 years ago
|
||
From what I can see, this is a regression from Bug 455942, specifically a regression from the ported Bug 447642.
This is due to not auditing our tree to s/MOZ_MOCHITEST/ENABLE_TESTS/ as in the original Bug.
Assignee | ||
Comment 3•16 years ago
|
||
(untested, but looks obvious)
Assignee: build-config → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #342602 -
Flags: review?(kairo)
Comment 4•16 years ago
|
||
Comment on attachment 342602 [details] [diff] [review]
(Av1) Replace missed variable
[Checkin: Comment 5]
Trivial enough that I can steal this review, I think.
Lets just be sure this change fixes the bug before resolving though.
Attachment #342602 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 342602 [details] [diff] [review]
(Av1) Replace missed variable
[Checkin: Comment 5]
http://hg.mozilla.org/comm-central/rev/79d1359df74a
Attachment #342602 -
Attachment description: (Av1) Replace missed variable → (Av1) Replace missed variable
[Checkin: Comment 5]
Assignee | ||
Comment 6•16 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1223681550.1223685536.8393.gz
Win2k3 comm-central dep unit test on 2008/10/10 16:32:30
953 + 51
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1223685203.1223689321.17094.gz
Win2k3 comm-central dep unit test on 2008/10/10 17:33:23
5584 + 82
V.Fixed
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
OS: Windows 2000 → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a2
Assignee | ||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•