Closed
Bug 456256
Opened 16 years ago
Closed 16 years ago
Resolve what to do with respect to completeDefaultIndex/autoFill/autoFillAfterMatch on SeaMonkey xpfe.
Categories
(SeaMonkey :: Autocomplete, defect)
SeaMonkey
Autocomplete
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: neil)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
(deleted),
patch
|
standard8
:
review+
Fallen
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jag+mozilla
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
After bug 325842 we have three attributes on xpfe autocomplete which do roughly the same thing:
- autoFill
This will extend the entry with a highlighted selection if the start of the entry matches the autocomplete suggestion.
- autoFillAfterMatch
Similar to autoFill, but if the string does not match the start of the best autocomplete suggestion, then it will indicate a match in the form "ar >> Mark" to indicate the replacement.
- completeDefaultIndex
This is the same as turning on autoFill and autoFillAfterMatch.
Assignee | ||
Comment 1•16 years ago
|
||
I think we should just switch everyone over from autoFillAfterMatch to completeDefaultIndex (and remove autoFillAfterMatch).
Comment 2•16 years ago
|
||
Sorry for setting the keyword... this "autocompletion" thing added it from nothing when I clicked on the field.
Keywords: 4xp
Assignee | ||
Comment 3•16 years ago
|
||
I'm assuming here that Calendar can stop using those really old attributes ;-)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #340740 -
Flags: review?(philipp)
Attachment #340740 -
Flags: review?(bugzilla)
Reporter | ||
Comment 4•16 years ago
|
||
Comment on attachment 340740 [details] [diff] [review]
What I said in comment #1
Looks good. I definitely agree we don't need those old attributes in the calendar file.
r=me.
Attachment #340740 -
Flags: review?(bugzilla) → review+
Comment 5•16 years ago
|
||
Comment on attachment 340740 [details] [diff] [review]
What I said in comment #1
Looks good, r=philipp
Attachment #340740 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Pushed changeset b990b5896c48 to comm-central.
Still need to remove autoFillAfterMatch from mozilla-central.
Assignee | ||
Comment 7•16 years ago
|
||
Conveniently the comment still applies to completeDefaultIndex ;-)
Attachment #342745 -
Flags: review?(ajschult)
Updated•16 years ago
|
Attachment #342745 -
Flags: superreview+
Attachment #342745 -
Flags: review?(ajschult)
Attachment #342745 -
Flags: review+
Assignee | ||
Comment 8•16 years ago
|
||
Pushed changeset 5d202f0c69e9 to mozilla-central.
Pushed changeset e40d9b4121f4 to releases/mozilla-1.9.1
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Keywords: fixed1.9.1
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1d9491c42039
autoFillAfterMatch is now completeDefaultIndex r+sr=jag NPOFB
You need to log in
before you can comment on or make changes to this bug.
Description
•