Closed
Bug 466078
Opened 16 years ago
Closed 16 years ago
gloda should stop setting folder (nsIMsgFolder) properties and exclusively use GlodaFolder dirty status
Categories
(MailNews Core :: Database, defect, P2)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
In the initial implementation of the 'indexing sweep', we used nsIMsgFolder properties to track their dirty status. Poor task tracking apparently left this half-implemented.
Needlessly setting these properties causes various flushes that have no reason to happen, not to mention we may have gaps in our current GlodaFolder dirty flag usage or persistence.
Flags: blocking-thunderbird3?
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #349728 -
Flags: review?(dmose)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs review dmose]
|
|
Assignee | |
Updated•16 years ago
|
Attachment #349728 -
Flags: review?(dmose) → review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 349728 [details] [diff] [review]
v1 complete dirty folder logic changes
The difference is now the dirty flag is not persistent across sessions. Is that OK?
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 349728 [details] [diff] [review]
v1 complete dirty folder logic changes
Andrew explained over irc that the dirty state would be persisted in the sqlite db. So I'll land this soon.
Attachment #349728 -
Flags: review?(bienvenu) → review+
|
|
||
Comment 4•16 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][needs review dmose]
|
||
Updated•16 years ago
|
Flags: blocking-thunderbird3?
You need to log in
before you can comment on or make changes to this bug.
Description
•