Closed
Bug 466492
Opened 16 years ago
Closed 16 years ago
Test for jar.mn in make to avoid invoking a subshell
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Currently, every chrome target (libs target) invokes a shell to test for the existence of jar.mn, and if it is present, to process it. We can use make $(wildcard) feature to bypass the extra shell invocation when jar.mn is not present (the common case). There is a slight trade-off here: we stat jar.mn every invocation of make... but I believe this is a low or no-cost operation on &nix systems, and is vastly overweighed by the cost of the extra process on Windows, so it should be a net win all around.
Attachment #349764 -
Flags: review?(ted.mielczarek)
Comment 1•16 years ago
|
||
Comment on attachment 349764 [details] [diff] [review] Test jar.mn using $(wildcard) to avoid extra shell, rev. 1 +ifndef NO_DIST_INSTALL libs realchrome:: $(CHROME_DEPS) $(FINAL_TARGET)/chrome -ifndef NO_DIST_INSTALL Nothing else is relying on this rule getting "$(CHROME_DEPS) $(FINAL_TARGET)/chrome" into the targets list, is it? You've changed the semantics slightly there with your moving of the ifndef NO_DIST_INSTALL, just want to make sure it doesn't have any strange side-effects.
Attachment #349764 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•16 years ago
|
||
Yeah, I know it changed slightly and I don't think it matters in this case: jar.mn + NO_DIST_INSTALL is a very strange combination that doesn't appear to actually exist anywhere.
Comment 3•16 years ago
|
||
Also, for this patch and the one on that other bug, remember to copy the changes to js/src/config as well. :)
Assignee | ||
Comment 4•16 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/211c2be2fa1e
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Attachment #349764 -
Flags: approval1.9.1?
Comment 5•16 years ago
|
||
Comment on attachment 349764 [details] [diff] [review] Test jar.mn using $(wildcard) to avoid extra shell, rev. 1 a191=beltzner
Attachment #349764 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 6•16 years ago
|
||
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9ca5b0c60e50
Keywords: fixed1.9.1
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•