Closed Bug 581151 Opened 14 years ago Closed 14 years ago

make chrome no longer works

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(status1.9.2 .9-fixed, status1.9.1 .12-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- .9-fixed
status1.9.1 --- .12-fixed

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: fixed-seamonkey2.0.9, regression)

Attachments

(1 file)

make chrome recursively invokes make realchrome. However the realchrome target is now conditional on the existence of a jar.mn file.
Attached patch Possible patch (deleted) — Splinter Review
I also considered moving the NO_DIST_INSTALL ifdef since it's an easier test.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #459551 - Flags: review?(me)
Comment on attachment 459551 [details] [diff] [review]
Possible patch

Actually this fix applies pretty obviously to c-c rules.mk too (with offset).
Attachment #459551 - Flags: review?(bugspam.Callek)
Comment on attachment 459551 [details] [diff] [review]
Possible patch

rs+ for c-c based on khuey's r+ for m-c.
Attachment #459551 - Flags: review?(bugspam.Callek) → review+
Pushed changeset b6e2a919b701 to mozilla-central.

Pushed changeset a0e75bd610cf to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 459551 [details] [diff] [review]
Possible patch

Seeking approval for all branches where this trivial build config regression is known to have landed. (Using f? instead of a?Tb3.x because I'm too lazy.)
Attachment #459551 - Flags: feedback?(bugzilla)
Attachment #459551 - Flags: approval1.9.2.9?
Attachment #459551 - Flags: approval1.9.1.12?
Comment on attachment 459551 [details] [diff] [review]
Possible patch

a=LegNeato for 1.9.2 and 1.9.1
Attachment #459551 - Flags: approval1.9.2.9?
Attachment #459551 - Flags: approval1.9.2.9+
Attachment #459551 - Flags: approval1.9.1.12?
Attachment #459551 - Flags: approval1.9.1.12+
Pushed changeset c3643db869bd to releases/mozilla-1.9.2

Pushed changeset ca834d8c9c54 to releases/mozilla-1.9.1
Attachment #459551 - Flags: feedback?(bugzilla)
Pushed changeset 69369e04b3bf to releases/comm-1.9.2

Pushed changeset 823d07f99704 to releases/comm-1.9.1

(I actually got a=Standard8 over IRC a couple of weeks ago)
(In reply to comment #8)
> Pushed changeset 69369e04b3bf to releases/comm-1.9.2

Backed this out in changeset 015dd7372a09 due to complete bustage on 1.9.2.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: