Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081204 Thunderbird/3.0b1 drag and drop subfolder to root of account is blocked/fails. i.e. drag a local second level folder (subfolder) to local account to make it a first level folder result: operation shows the drop is blocked works if dragging subfolder to another folder

This is true on Mac too! Build 3.0b2pre

Regression from tb2, and quite limiting, as there's no way to move back a folder other than dragging and dropping, in case you move it accidentally.

The reason is that the new code checks .canFileMessages regardless if it is a message or folder - http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#343 The old code used to do that check as well as a lot more.

This patch makes canDrop only check .canFileMessages when the drop types are messages.

There are other checks we probably still need to do for messages that were in the old code: targetFolder.isServer and checking not dropping into folder it is already in.

Comment on attachment 357240 [details] [diff] [review] Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9) Thx, r=mkmelin

Comment on attachment 357240 [details] [diff] [review] Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9) thx for the patch!

Comment on attachment 357240 [details] [diff] [review] Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9) http://hg.mozilla.org/comm-central/rev/47815c10e304

thanks Ian. verified 2009-01-24 build