Closed
Bug 472861
Opened 16 years ago
Closed 16 years ago
make mochitest steps wrap FAIL in <em class="testfail">
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
When mochitest steps crash, they TinderboxPrint FAIL. All (or at least most) of our other failure conditions wrap the fail text in <em class="testfail"> as we've added a high-contrast style to that on Tinderbox. We should add that here as well so it's extremely clear what's failing.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #356217 -
Flags: review?(bhearsum)
|
||
Updated•16 years ago
|
Attachment #356217 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Checking in unittest/steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v <-- steps.py
new revision: 1.19; previous revision: 1.18
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 3•16 years ago
|
||
Deployed too ? Perhaps we should adjust the attachment title, or set a whiteboard string to track that sort of thing.
|
|
Assignee | |
Comment 4•16 years ago
|
||
I didn't worry about deployment, I figured it wasn't critical and we'd pick it up whenever the next deployment happened.
|
|
Assignee | |
Comment 5•16 years ago
|
||
I think Webdev uses the "push-needed" keyword. We could try to remember to set that for buildbot config changes, and then whenever someone does an update/reconfig, they can remove it.
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•