Closed
Bug 475085
Opened 16 years ago
Closed 16 years ago
Mochitest leakThreshold should default to 0
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: Waldo, Assigned: sgautherie)
References
()
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b3])
Attachments
(1 file)
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
The current default is infinity, which we proceed to override when specific test harnesses are run -- but as of a day or so ago, we always override now. We should remove the maybe-override code and just always default to 0 to simplify the code.
Assignee | ||
Updated•16 years ago
|
Assignee | ||
Comment 1•16 years ago
|
||
(untested but obvious) From now on, Firefox (and the other apps) will have to rely on bug 460548.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #364019 -
Flags: review?(jwalden+bmo)
Reporter | ||
Comment 2•16 years ago
|
||
Comment on attachment 364019 [details] [diff] [review] (Av1) Set global default to 0 from infinity [Checkin: See comment 4] Thanks, I wanted to get to this eventually to simplify the code but hadn't found the time yet.
Attachment #364019 -
Flags: review?(jwalden+bmo) → review+
Reporter | ||
Comment 3•16 years ago
|
||
Do make sure to test this before landing to be safe, tho -- don't see how anything could go wrong with this, but you never know, I might have missed a typo or something.
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 364019 [details] [diff] [review] (Av1) Set global default to 0 from infinity [Checkin: See comment 4] http://hg.mozilla.org/mozilla-central/rev/07335395bc6f *** http://hg.mozilla.org/releases/mozilla-1.9.1/rev/add530abc9dc after fixing context for { patching file testing/mochitest/runtests.py.in Hunk #1 succeeded at 172 with fuzz 1 (offset -17 lines). Hunk #2 FAILED at 290 1 out of 4 hunks FAILED }
Attachment #364019 -
Attachment description: (Av1) Set global default to 0 from infinity → (Av1) Set global default to 0 from infinity
[Checkin: Comment 4]
Assignee | ||
Updated•16 years ago
|
Attachment #364019 -
Attachment description: (Av1) Set global default to 0 from infinity
[Checkin: Comment 4] → (Av1) Set global default to 0 from infinity
[Checkin: See comment 4]
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Keywords: fixed1.9.1
Resolution: --- → FIXED
Whiteboard: [fixed1.9.1b3]
You need to log in
before you can comment on or make changes to this bug.
Description
•