Closed
Bug 460382
Opened 16 years ago
Closed 16 years ago
Linux Firefox test boxes don't error on mochitest leaks
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Linux mozilla-central moz2-linux-slave07 dep unit test
Linux mozilla-central moz2-linux-slave08 dep unit test
See bug 459770 comment 4.
It's as if their leak threshold is not set (to 0).
Comment 1•16 years ago
|
||
Is this different from bug 445596 ?
Assignee | ||
Comment 2•16 years ago
|
||
Yes, unrelated:
the current leak turned "all" the other boxes to Orange,
but not these two.
Comment 3•16 years ago
|
||
What's the default if there's no leak threshold set? Did I screw up with http://hg.mozilla.org/build/buildbot-configs/rev/9b1948464cf3 (for Mac)?
Assignee | ||
Comment 4•16 years ago
|
||
Default for Mochitest on Linux is still INFINITY.
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py.in?mark=459-461#444
As it doesn't leak anymore (afaict), the Mac+Win test should be removed.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224212706.1224216186.10920.gz&fulltext=1
{
TEST-PASS | runtests-leaks | no leaks detected!
...
TinderboxPrint: mochitest<br/>71645/0/1522
}
*****
While there, maybe the default for BrowserChrome could be set now !?
(Someone would have to check what the current situation is.)
*****
Obviously, my wish would be that the default in the code is 0 for all (= no more INFINITY default);
and that each "project" set its own defaults as low as possible !
(As SeaMonkey has now ;-))
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #3)
> Did I screw up with http://hg.mozilla.org/build/buildbot-configs/rev/9b1948464cf3 (for Mac)?
No, that's fine.
(Fwiw, note that answering this kind of question is the whole point of bug 456275...)
Depends on: 456275
Assignee | ||
Comment 6•16 years ago
|
||
Review from either of you would be fine.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #343661 -
Flags: review?(ted.mielczarek)
Attachment #343661 -
Flags: review?(sayrer)
Updated•16 years ago
|
Attachment #343661 -
Flags: review?(ted.mielczarek)
Attachment #343661 -
Flags: review?(sayrer)
Attachment #343661 -
Flags: review+
Assignee | ||
Comment 7•16 years ago
|
||
Comment on attachment 343661 [details] [diff] [review]
(Av1) No leaks on Linux too
[Checkin: Comment 7]
http://hg.mozilla.org/mozilla-central/rev/5d95abb2eb1f
Attachment #343661 -
Attachment description: (Av1) No leaks on Linux too → (Av1) No leaks on Linux too
[Checkin: Comment 7]
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #4)
> While there, maybe the default for BrowserChrome could be set now !?
>
> Obviously, my wish would be that the default in the code is 0 for all (= no
> more INFINITY default);
I filed bug 460548.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•