Dave Townsend [:mossop] Assignee
	Description • 16 years ago

bug 389816 and bug 338611 introduced two cases where it is perfectly normal for the xpi request to be cancelled before the output stream for the file has been created which makes this assertion bogus.

We should either downgrade this to a warning or something or just remove it entirely.

	Dave Townsend [:mossop] Assignee
	Comment 1 • 16 years ago

Actually maybe moving the assertion makes most sense. It will assert if the request was successful but there isn't an output stream.

	Daniel Veditz [:dveditz]
	Comment 2 • 16 years ago

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

r/sr=dveditz

	Dave Townsend [:mossop] Assignee
	Comment 3 • 16 years ago

Pushed: http://hg.mozilla.org/mozilla-central/rev/a2460d14f637

	Dave Townsend [:mossop] Assignee
	Comment 4 • 16 years ago

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

Would like to land this on the 1.9.1 branch. It only affects debug builds so there is basically no risk to the Firefox product.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 5 • 16 years ago

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

a191=beltzner

	Dave Townsend [:mossop] Assignee
	Comment 6 • 16 years ago

Landed on branch http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2a11f4d6330c

	Dave Townsend [:mossop] Assignee
	Comment 7 • 16 years ago

Landed on 1.9.0.x branch:

Checking in xpinstall/src/nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v  <--  nsXPInstallManager.cpp
new revision: 1.169; previous revision: 1.168
done