Closed
Bug 476218
Opened 16 years ago
Closed 16 years ago
default archives folder of global-inboxed pop account is on incoming account, can't leave copies & folders account settings page
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: tuukka.tolvanen, Assigned: Bienvenu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
philor
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
(X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090128 Thunderbird/3.0b2pre
set up a pop account, have it store messages on "Local Folders". (I didn't try setting this up from scratch though, this was with old profile accounts.) Go to account settings copies & folders page for that account.
expected: archives folder default should be sane, e.g. "Archives" Folder on "Local Folders". The item selected by default shoudl exist in the drop-down for that selector. It should be possible to select another (e.g. the next) settings page in the tree.
result: archives folder default is "Archives" Folder on <name-of-this-incoming-account>, which is not available in the dropdown list. trying to switch to another account settings page fails:
Error: document.getElementById(accountPickerId).selectedItem is null
Source File: chrome://messenger/content/am-copies.js
Line: 294
Comment 1•16 years ago
|
||
"can't leave copies & folders account settings page" part is Bug 471344.
See also Bug 476217 for UI/back_end change in "Archive Folder" choice.
> Bug 476217 archive folder setting should not be per-identity
Reporter | ||
Updated•16 years ago
|
Comment 3•16 years ago
|
||
I don't think I quite read this right the first time, probably because it wasn't screaming "OMG, I USED UR DAMN ARCHIVE FEATURE AND MY MAIL JUST DISAPPEARED!!!1!," which is exactly what it appears to do for Local Folders.
Flags: blocking-thunderbird3?
OS: Linux → All
Hardware: x86 → All
Assignee | ||
Comment 4•16 years ago
|
||
I thought I fixed something like this...but if I didn't, it would definitely block b2.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b2
Comment 5•16 years ago
|
||
I thought so too, but if you did it must have been a "this is fixed for people who didn't ever run a nightly when it wasn't fixed" thing.
Comment 6•16 years ago
|
||
You didn't, I just set up a new POP account, deferred it to Local Folders, and it archives to the account instead of Local Folders.
Assignee | ||
Comment 7•16 years ago
|
||
this should repair bad account/identity prefs in existing profiles, and make new accounts have the correct prefs, in the case of deferred pop3 accounts.
Assignee: nobody → bienvenu
Attachment #363129 -
Flags: superreview?(bugzilla)
Attachment #363129 -
Flags: review?(philringnalda)
Assignee | ||
Comment 8•16 years ago
|
||
I should note that this will attempt to repair all special folders set to a deferred account, so it will deal with the case where the user defers an existing non-deferred account w/o changing their special folders.
Updated•16 years ago
|
Attachment #363129 -
Flags: review?(philringnalda) → review+
Comment 9•16 years ago
|
||
Comment on attachment 363129 [details] [diff] [review]
proposed fix
A touch over my head, but it does seem to fix all my ways of hitting it.
Assignee | ||
Comment 10•16 years ago
|
||
Thx, Phil, yes, I was in part asking for your r= because you already know how to test all this quickly.
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch, needs review Standard8]
Comment 11•16 years ago
|
||
Comment on attachment 363129 [details] [diff] [review]
proposed fix
Stealing sr since Standard8's busy and this is on the critical path for b2.
Attachment #363129 -
Flags: superreview?(bugzilla) → superreview?(dmose)
Updated•16 years ago
|
Attachment #363129 -
Flags: superreview?(dmose)
Updated•16 years ago
|
Attachment #363129 -
Flags: superreview+
Assignee | ||
Comment 12•16 years ago
|
||
checked into trunk, changeset http://hg.mozilla.org/comm-central/rev/0f1e556b8b37
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 13•16 years ago
|
||
Landed on release-branch:
changeset: 2043:b0e94b43a298
branch: COMM_20090224_RELBRANCH
tag: tip
user: David Bienvenu <bienvenu@nventure.com>
date: Fri Feb 20 12:37:40 2009 -0800
summary: fix handling of default archive folder for deferred pop3 accounts, r=philor, sr=neil, 476218
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch, needs review Standard8]
You need to log in
before you can comment on or make changes to this bug.
Description
•