Closed
Bug 476628
Opened 16 years ago
Closed 16 years ago
Switch nsMsgSendLater from nsISupportsArray to nsCOMArray
Categories
(MailNews Core :: Networking: SMTP, defect)
MailNews Core
Networking: SMTP
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
nsMsgSendLater currently stores message headers in an nsISupportsArray whilst processing them, we can improve the implementation by using nsCOMArray.
This should apply cleanly, if not it may need the patch from bug 476467.
Attachment #360292 -
Flags: superreview?(neil)
Attachment #360292 -
Flags: review?(neil)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 360292 [details] [diff] [review]
The fix
Two questions, while I'm compiling:
>+ nsCOMArray<nsIMsgDBHdr> mMessagesToSend;
Does this need to be a member?
Does this need to be <nsIMsgDBHdr>? All you do is enumerate it.
|
|
||
Updated•16 years ago
|
Attachment #360292 -
Flags: superreview?(neil)
Attachment #360292 -
Flags: superreview+
Attachment #360292 -
Flags: review?(neil)
Attachment #360292 -
Flags: review+
|
Assignee | |
Comment 2•16 years ago
|
||
(In reply to comment #1)
> (From update of attachment 360292 [details] [diff] [review])
> Two questions, while I'm compiling:
> >+ nsCOMArray<nsIMsgDBHdr> mMessagesToSend;
> Does this need to be a member?
> Does this need to be <nsIMsgDBHdr>? All you do is enumerate it.
I thought about this - I'm a little concerned about the possibility of the enumerator getting modified underneath us, especially as one of the comments in the file where we get the enumerator implies that is what may happen.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/896a340449d2
Marking as in-testsuite+ as the code here is covered by the existing send later unit tests.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•