Closed Bug 478443 Opened 16 years ago Closed 16 years ago

Alter makefiles slightly to make pymake happy

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

fix makefiles for pymake, rev. 1
(deleted), patch
ted
: review+
Details | Diff | Splinter Review
pymake has slightly different rules for how dependencies are calculated, and doesn't have an implicit definition of $(RM). Both of these are easily avoided.
Attachment #362246 - Flags: review?(ted.mielczarek)
Comment on attachment 362246 [details] [diff] [review] fix makefiles for pymake, rev. 1 -jsopcode.h jsopcode.cpp: jsopcode.tbl Does this change behavior at all, or is it effectively a no-op?
Attachment #362246 - Flags: review?(ted.mielczarek) → review+
It's a no-op: there's no command to remake jsopcode.h (or jsopcode.tbl) so the rule is effectively meaningless.
http://hg.mozilla.org/mozilla-central/rev/d17cb4c725bd
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
And http://hg.mozilla.org/mozilla-central/rev/301fedc33749 followup: something about the ordering of cross-compiles with -j4 means we were trying to create the dist/include/js directory before nsinstall was avaialable. deps suck
Blocks: 543295
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment on attachment 362246 [details] [diff] [review] fix makefiles for pymake, rev. 1 Ben, this config.mk hunk; appears to never have been committed; is that intended, or just a missed bit? (Though it also seems unrelated from reading this bug)
It was debugging code that I removed before checkin.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: