Closed Bug 543295 Opened 15 years ago Closed 15 years ago

Port |Bug 478443 -- Alter makefiles slightly to make pymake happy| to comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b1

People

(Reporter: Callek, Assigned: sgautherie)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #478443 +++

pymake has slightly different rules for how dependencies are calculated, and doesn't have an implicit definition of $(RM). Both of these are easily avoided.

For this port I'm only worried about the $RM stuff...
Assignee: nobody → sgautherie.bz
Severity: normal → trivial
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.1b1
Status: NEW → ASSIGNED
Flags: in-testsuite-
Attached patch (Av1) Just copy it [Checkin: Comment 4] (deleted) β€” β€” Splinter Review
Attachment #426147 - Flags: review?(bugspam.Callek)
Attachment #426147 - Flags: review?(bugspam.Callek) → review+
upon looking at the previous bug again (and closer) the config/config.mk actually might be useful, but is not required. [just has better error output]
(In reply to comment #2)
> "previous bug" ... "config/config.mk"

Which bug? Which changeset?
Comment on attachment 426147 [details] [diff] [review]
(Av1) Just copy it
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/a8155e4a4b06
Attachment #426147 - Attachment description: (Av1) Just copy it → (Av1) Just copy it [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #3)
> (In reply to comment #2)
> > "previous bug" ... "config/config.mk"
> 
> Which bug? Which changeset?

Hmm.. I was talking about 

https://bugzilla.mozilla.org/attachment.cgi?id=362246&action=diff

But it seems the config.mk change isn't part of the changesets listed as checkin.. I'll have to look further
(In reply to comment #5)
> But it seems the config.mk change isn't part of the changesets listed as
> checkin.. I'll have to look further

Ok that hunk was never pushed... ignore for now.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: