Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090214 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090214020701 To be able to scroll to the top/bottom of the download manager we should support the newly added multi-touch gestures.

I think it'd probably be dumb to do it in ever implementation - why not have the richlistbox do it?

I thought that too and already talked with Edward about it. Shall I better file a new bug for the richlistbox part and mark this bug and the error console one as dependend?

Bug 478606 has been transformed to cover the move to toolkit. Shall we add this bug to the dependency list? I think so. Even when it has been implemented any instance has to handle those events.

Generalize to richlist.. Should I just add the anon scrollbox as a member? Would be useful for writing a testcase to grab the scrollbox and see if the scrollTop actually changed.

I'm not the right reviewer for toolkit.

Comment on attachment 362495 [details] [diff] [review] v1 Oh oops. :p I searched for toolkit then searched for widget. Well.. I'll r? shawn for now but I'll probably need to find someone else too..

Comment on attachment 362495 [details] [diff] [review] v1 You want Neil for this.

So the MozSwipeGesture event means move the first (or last) item? I would have expected it to mean move by page. Or does the event not give any indicator of how far or how fast?

Mac OS X currently only reports the direction of the three-fingered swipe. The only multi-touch gestures with an associated magnitude are the zoom and rotate gestures. The "delta" attribute of SimpleGestureEvent is not used for swipe events.

Neil: Swipe up/down doesn't necessarily mean anything right now. In the main browser of Firefox, it goes to the top/bottom of the page. But it could just as well mean "open new tab" or "close tab". 3-finger swipe up/down has been pretty useful in going to the top/bottom of the page though. So that's why the generalization to richlistboxes and trees. But then that means implementing swipe up/down as top/bottom for most other things as well down the line... maybe?

Comment on attachment 362495 [details] [diff] [review] v1 OK, but why not put this in listbox.xml so listboxes can have the same behaviour?

http://hg.mozilla.org/mozilla-central/rev/6664e8582fee We should be able to send a swipe mouse event on a download manager chrome test.. checking if it actually scrolled... probably getAnonymousElementByAttribute main-box and check scrollTop?

Edward, do you plan to file a new bug or open this one for the removal of the needless handler in the richlistbox binding? We already have it in the listbox binding. See bug 478939.

The listbox swipe handling is in the listbox binding but richlistbox extends listbox-base. The listbox implementation uses ensureIndexIsVisible which is implemented as part of listbox but not listbox-base.

Means no further change will be made here and this bug can be verified?

Sure. I suppose we can wait a few days to bake.. I think that's part of the approval process guidelines..

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633

Comment on attachment 362495 [details] [diff] [review] v1 Please re-nominate when you have tests.