Closed
Bug 482440
Opened 16 years ago
Closed 16 years ago
Provide aria-controls attribute on searchtextbox widgets
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dmosedale
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
After landing of bug 469367 on m-1.9.1, aria-controls should be added to the XUL:textbox @type="search" controls to indicate which of the UI elements is being searched. Together with the textbox widget enhancements from bug 469367, this will allow screen readers to give a rpoper representation of what's being searched.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #366540 -
Flags: superreview?(dmose)
Attachment #366540 -
Flags: review?(dmose)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 366540 [details] [diff] [review]
Patch
Apologies for not getting to this sooner. Unfortunately, as a result, this code has had significant change since the patch was posted and it no longer applies. Normally, I'd just forward-port this myself, since the bit-rot is my fault. In this case, however, it's not obvious exactly what changes to make, and since I'm not in a position to easily test this, I'm leery of just pushing forward with that. Can I convince you to take another run at a patch on the updated UI? If so, I promise I'll review much more quickly!
Attachment #366540 -
Flags: superreview?(dmose)
Attachment #366540 -
Flags: review?(dmose)
|
|
Assignee | |
Comment 3•16 years ago
|
||
This patch takes care of all remaining textbox @type="search" fields in mail and mailnews.
Attachment #366540 -
Attachment is obsolete: true
Attachment #373067 -
Flags: superreview?(dmose)
Attachment #373067 -
Flags: review?(dmose)
|
|
||
Updated•16 years ago
|
Attachment #373067 -
Flags: superreview?(dmose)
Attachment #373067 -
Flags: superreview+
Attachment #373067 -
Flags: review?(dmose)
Attachment #373067 -
Flags: review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 373067 [details] [diff] [review]
Updated patch
r+sr=dmose; thanks for the patch!
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•