Closed
Bug 485171
Opened 16 years ago
Closed 15 years ago
[bn-BD] Increment gecko.handlerService.defaultHandlersVersion in order for the Mibbit irc handler to work
Categories
(Mozilla Localizations :: bn-BD / Bengali, defect)
Mozilla Localizations
bn-BD / Bengali
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
(deleted),
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
The following revision added the Mibbit handler to region.properties:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bn-BD/diff/6bbff1d02bed/browser/chrome/browser-region/region.properties
Please note that this landing is not complete. For the handler to work on all profiles, the gecko.handlerService.defaultHandlersVersion pref (also in region.properties) needs to be incremented by 1.
Please submit a patch for a review.
Please also note that any changes to region.properties (and searchplugins/) need to go through a review process. Thanks for keeping that in mind in the future :)
Reporter | ||
Comment 1•16 years ago
|
||
Ping? :)
Reporter | ||
Comment 2•16 years ago
|
||
Jamil, could you please provide a patch for review? Thanks!
Reporter | ||
Updated•16 years ago
|
Blocks: fx35-l10n-bn-BD
Comment 3•16 years ago
|
||
stas, can you please provide me some more details? i am confused.
Reporter | ||
Comment 4•16 years ago
|
||
Hi Jamil. Sure: please attach a patch to this bug with a following change: in region.properties gecko.handlerService.defaultHandlersVersion=2 should be changed to gecko.handlerService.defaultHandlersVersion=3.
After you attach the patch, I'll review it and you will be able to land it. If you land it in the next 2 hours, we might be able for this change to make it into beta4, in which case we'll have to give a new revision number to Axel for the opt-in.
Does this sound clear? Always happy to chat on IRC with you about it, if you feel like it (I'm "stas" in #l10n).
Comment 5•16 years ago
|
||
Comment 6•16 years ago
|
||
Stas: sorry, I might not be able to land it by the time. I need to run for an urgent issue. Can you please land it on behalf of me?
Reporter | ||
Comment 7•16 years ago
|
||
Comment on attachment 372848 [details] [diff] [review]
Patch for the change.
Thanks Jamil. No worries, I'll land it.
Attachment #372848 -
Flags: review+
Reporter | ||
Comment 8•16 years ago
|
||
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bn-BD/rev/4faaa252f80f
Fixed on 1.9.1. Please land it on l10n-central, too, and change this bug's status to resolved fixed.
Keywords: fixed1.9.1
Comment 9•15 years ago
|
||
FIXED on 1.9.1 and 1.9.2. Resolving.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•