User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.5.30729; .NET CLR 3.0.30618) Build Identifier: GCThreadLocal class uses Win32/Posix APIs for implementing TLS. In the spirit of porting, we need replace these with appropriate VMPI APIs. Reproducible: Always

Comment on attachment 372422 [details] [diff] [review] [v1] patch I think we shouldn't compile (or not link) if someone tries to compile ThreadsPosix and there's no pthreads, the default impl provided here is just broken.

So just get rid of the default implementation?

Also, I think that vmpi_tls_id_t is unnecessary. I intend to replace that with uintptr_t in the APIs.

Comment on attachment 372422 [details] [diff] [review] [v1] patch + with the default unix impl taken out

actually I take that back, there seems to be some missing manifest file updates for the xp build system

I have added ThreadsWin.cpp to VMPI/manifest.mk

doh, not sure how I missed that...

changeset 1763 052befa27baf