Robert Kaiser Reporter
	Description • 16 years ago

This is the comm-central version of bug 485935, we should do this for all our apps as well.

	Robert Kaiser Reporter
	Comment 1 • 15 years ago

Holding off on this until bug 485935 comment #9 is addressed.

	Serge Gautherie (:sgautherie)
	Comment 2 • 15 years ago

Bug 521523 ported this for SeaMonkey 2.1a1.

	Phil Ringnalda (:philor)
	Comment 3 • 15 years ago

Since apparently the only reason for building it was to enable bug 485860, but the way bug 485935 did it did not enable that and nobody who understands the problem has even filed the followup bug to do it in a way that will work for automation, I don't see any point in porting it unless the goal is actually to produce and upload them for nightlies, which does work, rather than the stated goal of releases, which does not.

	Robert Kaiser Reporter
	Comment 4 • 15 years ago

I think having it available for nightlies is already< a good first step, bringing it into release uploads should only be an additional step. Thos who want it for a release can use a langpack from a nightly near to the release, if that works.

In any case, I believe that Sunbird isn't really a topic on trunk and more and the SeaMonkey side has been done, so moving this to Thunderbird.

	Mark Banner (:standard8) Assignee
	Comment 5 • 15 years ago

This patch takes care of both nightly and releases (afaict), although maybe a bit hacky (we can always port revised fix later, but I saw someone asking today, so this just fixes it up).

- This patch doesn't create a new target in mail/locales like FF does. We don't need it. It seems like "couldn't be bothered" took over in comments 2 and 3 in that bug.

- It takes account of MOZ_PKG_PRETTYNAMES being set and will land the xpi in the appropriate place (either mac/xpi/en-US.xpi or just en-US.xpi)

- Fixes expanding of toolkit/locales source directory so that it includes mozilla/ which is needed for being called from mail/installer.

	Phil Ringnalda (:philor)
	Comment 6 • 15 years ago

Comment on attachment 430287 [details] [diff] [review]
The fix

wfm

	Mark Banner (:standard8) Assignee
	Comment 7 • 15 years ago

Checked in: http://hg.mozilla.org/comm-central/rev/3089a5d8bd1d

	Dan Mosedale (:dmosedale, :dmose)
	Comment 8 • 15 years ago

Since we haven't branched comm-central yet, this is done.  Thanks, Mark!

	Mark Banner (:standard8) Assignee
	Comment 9 • 15 years ago

Strictly speaking this isn't 100% fixed as we don't upload the en-US langpacks to the servers (even though we do generate them now).

I've raised bug 551449 on the buildbot changes to make that happen.