Closed Bug 488710 Opened 16 years ago Closed 16 years ago

Upgrade to sqlite 3.6.7 on the 1.9.0 branch

Categories

(Toolkit :: Storage, defect)

1.9.0 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: samuel.sidler+old, Assigned: sdwilsh)

References

Details

(Keywords: verified1.9.0.11)

Attachments

(1 file)

This is the 1.9.0-specific version of bug 471685. There's a bunch of crashes and various other issues with the sqlite we're currently shipping on the 1.9.0 branch. We'd like to upgrade sqlite to the version that shipped in Firefox 3.1 beta 3, which seems more stable and has had a good amount of baking, since it shipped in a beta. Shawn, can you attach a patch for us to approve? It'd also help to know what bugs this will fix on 1.9.0, but don't worry about compiling that right away unless you happen to have it handy.
Flags: blocking1.9.0.10?
Depends on: 471685
The patch will be too big to attach to bugzilla, so it's a bit hard to attach. I can do the moz-changes patch like usual if you want though...
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Yeah, that's what I meant, sorry.
Flags: wanted1.9.0.x+
Attached patch v1.0 (deleted) — Splinter Review
For all intents and purposes, this is r=asuth from bug 471685 attachment 355441 [details] [diff] [review]
Attachment #373195 - Flags: approval1.9.0.10?
As for bugs this should fix: bug 462476 bug 446118 bug 444446 bug 443577
Blocks: 462476
Whiteboard: [needs approval]
Flags: blocking1.9.0.10?
Comment on attachment 373195 [details] [diff] [review] v1.0 Approved for 1.9.0.10, a=dveditz for release-drivers
Attachment #373195 - Flags: approval1.9.0.10? → approval1.9.0.10+
Oh how I loathe the, CVS... Checking in configure.in; new revision: 1.2002; previous revision: 1.2001 Checking in db/sqlite3/README.MOZILLA; new revision: 1.31; previous revision: 1.30 Checking in db/sqlite3/src/sqlite3.h; new revision: 1.25; previous revision: 1.24 Checking in db/sqlite3/src/sqlite3.c; new revision: 1.22; previous revision: 1.21
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs approval]
sqlite.def needed changing, and I forgot to do it: Checking in db/sqlite3/src/sqlite.def; new revision: 1.15; previous revision: 1.14
Keywords: fixed1.9.0.10
Blocks: 423943
Verified that this is checked in. Marking for 1.9.0.11.
Status: RESOLVED → VERIFIED
(folks, you didn't name this bug id in the 1.9.0 commit :)). The change in configure.in kind of hit us. In ubuntu intrepid xulrunner now fails to build because our system lib is lower. Was there any other landing that would require us to take a newer sqlite lib (besides from the general fixes mentioned in the bug description)?
There are a number of crash bugs that were fixed by upgrading. They were all marked with the appropriate keywords.
Alexander: Maybe bug 487660?
Oh - yes, that'd be an important one that was fixed by this.
The upgrade has been caused bug 497792 which let OS X users not access their profiles which are located on AFP network shares.
No longer depends on: 502283
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: