Closed
Bug 488738
Opened 16 years ago
Closed 15 years ago
make GCHeap infrastructure memory come from MMgc
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)
Tamarin Graveyard
Garbage Collection (mmGC)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: treilly, Assigned: treilly)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
Most of this has been fixed, some left:
GCHeap::Region
GCHeap::HeapBlock array
GCAlloc instances
Comment 1•16 years ago
|
||
Does this mean you'll get rid of GCAllocObject in favor of eg factory methods? I would welcome that...
Assignee | ||
Comment 2•16 years ago
|
||
Not sure what you mean, when this is done the memory profiler will still use it although I hate the name, SystemAllocObject would be better I think
Assignee | ||
Comment 3•15 years ago
|
||
refining to GCHeap things to focus bug and separate from similar profiler bug
Assignee: nobody → treilly
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Summary: make all release GC infrastructure memory come from MMgc → make GCHeap infrastructure memory come from MMgc
Assignee | ||
Comment 4•15 years ago
|
||
Specifically this bug now refers to just the GCHeap instance, Region's and the HeapBlock array.
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.x
Updated•15 years ago
|
Flags: flashplayer-triage+
Assignee | ||
Comment 5•15 years ago
|
||
HeapBlock array will be handled in a separate patch
Attachment #399921 -
Flags: superreview?(lhansen)
Assignee | ||
Comment 6•15 years ago
|
||
GCHeap::Region not handled yet either
Comment 8•15 years ago
|
||
Following is a case of GCHeap memory coming from system -
GCHeap data members that are of type BasicList or use BasicList indirectly, examples gcManager::collectors and callbacks.
When MMGC_USE_SYSTEM_MALLOC is defined the delete call gets routed to SystemDelete which calls GetGCHeap()->TrackSystemFree(). During an OOM condition, GCHeap::Leave() nulls out the GCHeap::instance singleton prior to destroying gcheap instance. This results in a NULL pointer crash in SystemDelete().
Assignee | ||
Comment 9•15 years ago
|
||
Updated•15 years ago
|
Attachment #399921 -
Flags: superreview?(lhansen) → superreview+
Assignee | ||
Comment 10•15 years ago
|
||
Note that we also have to fix all callers of mmfx_new (GCAlloc, GCLargeAlloc and BasicList)
Assignee | ||
Comment 11•15 years ago
|
||
Passes sanities and ATS in player
Attachment #400656 -
Attachment is obsolete: true
Attachment #404663 -
Flags: superreview?(lhansen)
Comment 12•15 years ago
|
||
Comment on attachment 404663 [details] [diff] [review]
allocates heap blocks from our memory
I'm not happy with the complexity of ExpandHeapInternal (and we have to consider bug #520080 soon) but this should be OK for now.
Attachment #404663 -
Flags: superreview?(lhansen) → superreview+
Assignee | ||
Comment 13•15 years ago
|
||
pushed changeset: 2698:01908e2ae607
Assignee | ||
Comment 14•15 years ago
|
||
This should be it for this bug.
Attachment #405113 -
Flags: superreview?(lhansen)
Updated•15 years ago
|
Attachment #405113 -
Flags: superreview?(lhansen) → superreview+
Assignee | ||
Comment 16•15 years ago
|
||
changeset: 2745:c1a3b9cba0e3
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 17•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•