This includes both C++ APIs (where we already have weak references) and AS3 APIs.

Comment on attachment 375780 [details] [diff] [review] Preliminary cleanup redux changeset: 5e640ff116ee

(In reply to comment #2) > (From update of attachment 375780 [details] [diff] [review]) > redux changeset: 5e640ff116ee That patch was later reverted because it did not work on all platforms (for reasons not yet known) - the abcasm/coverage/G tests failed (core dump) on win, win64, ppc64, winmo.

Fix confusing and incorrect naming convention in avmcore, and users; fix improper cast to GCObject in hash table code by avoiding the need for a cast. My confusion in the previous patch was that the AvmCore functions gcObjectToAtom and atomToGCObject and isGCObject don't actually operate on GCObject values at all; they operate on void* and names should reflect that. Fixing the names also exposes the dodgy (but accidentally working) code in the hash tables that needs cleanup: it casts a void* to GCObject but the representation could actually be GCFinalizedObject (which has a vtable and looks different).

Comment on attachment 380437 [details] [diff] [review] Clean up confusing code around weak refs approved, but could you please use atomPtr(a) instead of (a&~7), and atomKind(a) instead of (a&7)?

Comment on attachment 380437 [details] [diff] [review] Clean up confusing code around weak refs redux changeset: 1966:373bf5d9630b I did clean up the bit operations as requested.

Closing this as we have no requirement for those features at this time and no pending patches.

bulk verifying resolved !fixed issues