Closed
Bug 493237
Opened 16 years ago
Closed 15 years ago
Enable crash stack display on leaktest builds
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: catlee)
References
Details
Attachments
(1 file)
(deleted),
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
The leaktest builds currently don't run minidump_stackwalk on crashes. They are using automation.py, so this is probably as simple as making sure we run `make buildsymbols` on them and then make sure that MINIDUMP_STACKWALK is set properly in the environment: this is the same thing we do for unittest machines.
Updated•16 years ago
|
Assignee: nobody → bhearsum
Priority: -- → P2
Updated•16 years ago
|
Assignee: bhearsum → nobody
Priority: P2 → P3
Comment 1•16 years ago
|
||
I believe the leak test machines will be going away in favor of debug unit test machines, so that may cover this. (Correct me if I'm mistaken.)
Depends on: 372581
Comment 2•16 years ago
|
||
I'm going to future this as the work on debug unit tests should cover it/take precedence.
Component: Release Engineering → Release Engineering: Future
Assignee | ||
Comment 4•15 years ago
|
||
We still need this for the leak tests.
Assignee: nobody → catlee
Component: Release Engineering: Future → Release Engineering
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #421977 -
Flags: review?(nrthomas)
Comment 6•15 years ago
|
||
Comment on attachment 421977 [details] [diff] [review]
Add MINIDUMP_STACKWALKER for leak tests, and make check.
Looks fine, r+
Attachment #421977 -
Flags: review?(nrthomas) → review+
Comment 7•15 years ago
|
||
Comment on attachment 421977 [details] [diff] [review]
Add MINIDUMP_STACKWALKER for leak tests, and make check.
changeset: 575:574d8732fc8c
Attachment #421977 -
Flags: checked-in+
Comment 8•15 years ago
|
||
I reconfig'ed pm01 and pm02 for this.
Comment 9•15 years ago
|
||
I don't know how to test this fix, so I'm going to assume it worked. I'll watch out for leak test crashes this week and re-open if they're still stackless.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•